Replace all instances of Guava cache with Caffeine #3206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caffeine is the replacement for Guava and has several improvements. This commit replaces all instances of Guava with Caffeine for consistency and also adds a checkstyle rule to prevent using Guava in the future.
|
Kicked off full IT build |
|
Full IT build passed successfully |
DomGarguilo
reviewed
Feb 27, 2023
core/src/main/java/org/apache/accumulo/core/classloader/URLContextClassLoaderFactory.java
Outdated
Show resolved
Hide resolved
ctubbsii
reviewed
Mar 3, 2023
core/src/main/java/org/apache/accumulo/core/file/blockfile/impl/CachableBlockFile.java
Show resolved
Hide resolved
server/manager/src/main/java/org/apache/accumulo/manager/recovery/RecoveryManager.java
Show resolved
Hide resolved
cshannon
added a commit
to cshannon/accumulo
that referenced
this pull request
Mar 3, 2023
* Narrow catch block for exception handling to only UncheckedIOException * Fix google cache regex in checkstyle rules
cshannon
added a commit
that referenced
this pull request
Mar 3, 2023
asfgit
pushed a commit
that referenced
this pull request
Mar 7, 2023
Remove unused ignored variable added by #3206
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caffeine is the replacement for the Guava cache api and has several improvements including efficiency with its admission policy and performance. Currently the Accumulo code base has a mixture where some places use Guava and some places use Caffeine so it is not consistent. Switching to Caffeine is nearly a drop in replacement and this commit replaces all instances of Guava with Caffeine for consistency and also adds a checkstyle rule to prevent using Guava in the future.
From the Guava docs regarding Caffeine: