Remove remaining master references #3361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Relocate Thrift classes in master.thrift to manager.thrift that are still in use * Remove unused RecoveryException thrift class * Update references to LICENSE files in git repos to local bundled copies * Remove transition checks for slaves/masters files and services in our assembly scripts and configs * Update generated property docs to clarify that `master.*` were the former names and are not still currently available * Update SimpleLoadBalancer javadoc to remove reference to deleted file (residual from apache#3117) * Stop updating ZK in SetGoalState, as that should have already been done when upgrading to 2.1, and close ServerContext with try-with-resources in that class * Remove unused RenameMasterDirInZK class (called by SetGoalState, but no more) * Update javadoc for KeywordExecutable to point to correct main branch in AutoService repo This fixes apache#2487
keith-turner
approved these changes
Apr 28, 2023
EdColeman
reviewed
Apr 28, 2023
server/manager/src/main/java/org/apache/accumulo/manager/state/SetGoalState.java
Show resolved
Hide resolved
EdColeman
approved these changes
Apr 28, 2023
There was a problem hiding this comment.
LGTM - maybe add a comment on the try-with-resources that close is okay and expected in that context, but also okay if you feel it is unnecessary.
When I was looking at that code it gave me pause and a comment would have clarified that it was safe / expected without needing to understand why it was safe in that context.
I suspect it gave you pause because you know extra things about how context is passed around widely in other threads inside our server classes. But that's clearly not the case here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
master.*were the former names and are not still currently availableThis fixes #2487