Skip to content

Use memory percentage for GC batch size#3725

Merged
ctubbsii merged 2 commits into
apache:2.1from
jmark99:gcbatchmem
Sep 29, 2023
Merged

Use memory percentage for GC batch size#3725
ctubbsii merged 2 commits into
apache:2.1from
jmark99:gcbatchmem

Conversation

@jmark99

@jmark99 jmark99 commented Aug 25, 2023

Copy link
Copy Markdown
Contributor

Update Accumulo to use a memory percentage value to determine the candidate batch size for garbage collection.

Updated Property.java to use a memory type rather than a bytes type.

Added logging to print the size and percentage used by the GC.

Update Accumulo to use a memory percentage value to determine the
candidate batch size for garbage collection.

Updated Property.java to use a memory type rather than a bytes type.

Added logging to print the size and percentage used by the GC.

@ctubbsii ctubbsii left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be a much more trivial PR than this. I think the only file that needs changing is Property.java. The other files can stay unchanged.

Comment thread server/gc/src/main/java/org/apache/accumulo/gc/GCRun.java Outdated
Comment thread core/src/main/java/org/apache/accumulo/core/conf/Property.java Outdated
Comment thread server/gc/src/main/java/org/apache/accumulo/gc/SimpleGarbageCollector.java Outdated
Comment thread test/src/main/java/org/apache/accumulo/test/functional/GarbageCollectorIT.java Outdated
Simplified PR as per suggestion to only a single change in the
Property.java file.
@markowens

markowens commented Sep 21, 2023

Copy link
Copy Markdown

@ctubbsii, simplified PR to the single change in Property.java as per suggestion.

@ctubbsii ctubbsii merged commit 51124ad into apache:2.1 Sep 29, 2023
@ctubbsii ctubbsii linked an issue Sep 29, 2023 that may be closed by this pull request
@jmark99 jmark99 deleted the gcbatchmem branch October 11, 2023 14:33
@ctubbsii ctubbsii modified the milestones: 3.1.0, 2.1.3 Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use memory percentage for GC batch size.

4 participants