New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc performance improvements #379

Merged
merged 1 commit into from Feb 9, 2018

Conversation

Projects
None yet
4 participants
@keith-turner
Contributor

keith-turner commented Feb 8, 2018

  • Avoid computing audit log message when level is not enabled
  • Faster hash function in thrift transport key
  • Avoid accessing site config for frequently accessed properties
misc performance improvements
 * Avoid computing audit log message when level is not enabled
 * Faster hash function in thrift transport key
 * Avoid accessing site config for frequently accessed properties
@@ -840,7 +840,7 @@ public static boolean isValidTablePropertyKey(String key) {
public static final EnumSet<Property> HOT_PATH_PROPERTIES = EnumSet.of(Property.TSERV_CLIENT_TIMEOUT, Property.TSERV_TOTAL_MUTATION_QUEUE_MAX,
Property.TSERV_ARCHIVE_WALOGS, Property.GC_TRASH_IGNORE, Property.TSERV_MAJC_DELAY, Property.TABLE_MINC_LOGS_MAX, Property.TSERV_MAJC_MAXCONCURRENT,
Property.REPLICATION_WORKER_THREADS, Property.TABLE_DURABILITY, Property.INSTANCE_ZK_TIMEOUT, Property.TABLE_CLASSPATH,
Property.MASTER_METADATA_SUSPENDABLE);
Property.MASTER_METADATA_SUSPENDABLE, Property.TABLE_FAILURES_IGNORE, Property.TABLE_SCAN_MAXMEM);

This comment has been minimized.

@ctubbsii

ctubbsii Feb 8, 2018

Member

I really think this HOT_PATH_PROPERTIES thing is confusing. We should probably build this static set from properties which have a specific annotation... an annotation with a good javadoc and a better name than "Hot Path".

@keith-turner keith-turner merged commit 3a6f0d7 into apache:1.8 Feb 9, 2018

1 of 2 checks passed

Jenkins Looks like there's a problem with this pull request
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mikewalch mikewalch added the v1.9.0 label Apr 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment