Modified ExternalCompactionUtil.findCompactionCoordinator to use ZooCache#3813
Merged
dlmarion merged 2 commits intoapache:2.1from Oct 5, 2023
Merged
Modified ExternalCompactionUtil.findCompactionCoordinator to use ZooCache#3813dlmarion merged 2 commits intoapache:2.1from
dlmarion merged 2 commits intoapache:2.1from
Conversation
Contributor
Author
|
Full IT build kicked off |
keith-turner
approved these changes
Oct 4, 2023
ctubbsii
requested changes
Oct 5, 2023
Member
ctubbsii
left a comment
ctubbsii
left a comment
There was a problem hiding this comment.
Looks good, but the UTF-8 issue should be fixed. I looked around and found other issues, and created #3815 as a follow-on to this to address those.
The suggested refactoring to leverage Optional to make the code more concise is merely a suggestion, but I recently made similar changes in #3788 for the main branch, so it's possible that similar changes here may make merging forward a little easier (I'm not sure, I didn't try).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3783