fixes bug with bulk import RPC failure and retry#4000
Merged
keith-turner merged 2 commits intoapache:2.1from Nov 30, 2023
Merged
fixes bug with bulk import RPC failure and retry#4000keith-turner merged 2 commits intoapache:2.1from
keith-turner merged 2 commits intoapache:2.1from
Conversation
The bulk import code had a bug where if an exception was thrown in a certain place in the tablet code that it would mark the bulk import as complete. After the exception, other code would retry and see the bulk import was complete even though it was not. This commit changes the behavior to only note success when there is no exception. In addition test were added that recreated this bug. These test set a constraint on the metadata table that cause bulk import writes to fail.
Contributor
Author
|
While working on this I also noticed #4001, but was a slightly uncertain about the fix. |
ivakegg
approved these changes
Nov 30, 2023
EdColeman
approved these changes
Nov 30, 2023
EdColeman
approved these changes
Nov 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bulk import code had a bug where if an exception was thrown in a certain place in the tablet code that it would mark the bulk import as complete. After the exception, other code would retry and see the bulk import was complete even though it was not. This commit changes the behavior to only note success when there is no exception. In addition test were added that recreated this bug. These test set a constraint on the metadata table that cause bulk import writes to fail.