New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #404 Provide Grafana dashboard for metrics #403

Merged
merged 3 commits into from Mar 22, 2018

Conversation

Projects
None yet
2 participants
@mikewalch
Member

mikewalch commented Mar 16, 2018

  • Also, enabled more reporting of ingest/scan metrics
@mikewalch

This comment has been minimized.

Member

mikewalch commented Mar 16, 2018

I am also working on a separate PR that will contain instructions for setting up metrics on InfluxDB & Grafana that will go into 1.9 & 2.0

@mikewalch

This comment has been minimized.

Member

mikewalch commented Mar 16, 2018

The metrics can be set up quickly using uno setup accumlo --with-metrics in this PR apache/fluo-uno#173

Fixes #404 Provide Grafana dashboard for metrics
* Also, enabled more reporting of ingest/scan metrics

@mikewalch mikewalch changed the title from ACCUMULO-4850 Provide Grafana dashboard for metrics to Fixes #404 Provide Grafana dashboard for metrics Mar 16, 2018

@mikewalch

This comment has been minimized.

Member

mikewalch commented Mar 16, 2018

PR for instructions for setting up metrics in Grafana/InfluxDB: apache/accumulo-website#62

@mikewalch

This comment has been minimized.

Member

mikewalch commented Mar 16, 2018

From review of apache/accumulo-website#62, I am going to move the grafana-dashboard.json out of this PR. Not 100% sure where yet.

@ctubbsii

+1 for the additional metrics, but would prefer grafana dashboard configuration not be included, since we don't need to ship configuration for external components outside the scope of Accumulo.

Based on the conversation in apache/accumulo-website#62, I think it would be best to link to Uno's grafana configuration in a dashboard, as an example of how to present Accumulo's metrics.

<artifactId>apache-rat-plugin</artifactId>
<configuration>
<excludes>
<exclude>conf/templates/grafana-dashboard.json</exclude>

This comment has been minimized.

@ctubbsii

ctubbsii Mar 19, 2018

Member

This isn't needed anymore.

This comment has been minimized.

@mikewalch

mikewalch Mar 19, 2018

Member

It has been removed.

@mikewalch mikewalch merged commit bf53114 into apache:1.8 Mar 22, 2018

2 checks passed

Jenkins This pull request looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mikewalch mikewalch deleted the mikewalch:metrics-1.8 branch Apr 4, 2018

@mikewalch mikewalch added the v1.9.0 label Apr 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment