Fix bug in compaction props (reapply #4092) #4117
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in the compaction properties to ensure the replacement
property is always preferred over the deprecated open.max compaction
property when it is set.
Add tests for maxOpen to override open.max:
service will override the deprecated
open.maxproperty if setproperty
value
the
<service>.planner.opts.propertiesThis is a reapplication of #4092 after it was reverted, to use
SiteConfiguration for testing overrides rather than modifications to
ConfigurationCopy
Changes made by ctubbsii that diverge from #4092:
is now OBE, to add a parent to preserve its role as a simple "flat"
configuration object for testing and simple operations
with a parent, to test override behavior for
DefaultCompactionPlannerTest
Co-authored-by: Christopher Tubbs ctubbsii@apache.org