-
Notifications
You must be signed in to change notification settings - Fork 476
Add Compaction Job Min & Max Wait properties #4223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Adds a property to configure the max wait interval in the compactor Also changes the logic in compaction-coordinator to use this new property when calculating the wait period for sending warning messages
Refactored check property to match elasticity property. Adds in min wait property for compaction job queue checks
Also use the MAX_JOB_WAIT_TIME prop for the thrift retry interval when the compactor is unable to communicate with the compaction-coordinator.
server/compactor/src/main/java/org/apache/accumulo/compactor/Compactor.java
Show resolved
Hide resolved
|
Talked with @EdColeman about this PR.
The underlying thrift call is not using these properties and remains unaffected.
Attempted to correctly calculate the Upon further review, the RetryableThriftCall has logging logic that would display log messages of warn during this infinite wait state. This meets the expectation that the user can determine that the compactor is not hung and is looking for work. |
server/compactor/src/main/java/org/apache/accumulo/compactor/Compactor.java
Outdated
Show resolved
Hide resolved
Use the minJobWait value instead of a hardcoded one second value.
Adds a property to configure the max wait interval in the compactor as well as the minimum wait period.
Changes the logic in compaction-coordinator to use this new property when calculating the wait period for sending warning messages
closes #4217