Throw error when non-standard chars exist #4348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an explicit error message when base64 coding should have been used. Adds override flag to generate human-readable output.
keith-turner
reviewed
Mar 8, 2024
core/src/main/java/org/apache/accumulo/core/file/rfile/GenerateSplits.java
Outdated
Show resolved
Hide resolved
keith-turner
reviewed
Mar 8, 2024
core/src/test/java/org/apache/accumulo/core/file/rfile/GenerateSplitsTest.java
Outdated
Show resolved
Hide resolved
Removes the new "human-readable" flag in favor of user using `base64 -d`. Removes specical handling of `\` character and replaces it with an allowed character set.
keith-turner
approved these changes
Mar 11, 2024
core/src/main/java/org/apache/accumulo/core/file/rfile/GenerateSplits.java
Outdated
Show resolved
Hide resolved
…eSplits.java Co-authored-by: Keith Turner <kturner@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an explicit error message when base64 encoding should have been used.
Removes special character modification in favor of the user piping the output to
base64 -dcloses: 4347