New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #441 only dereference WALs after minc finishes #443

Merged
merged 2 commits into from Apr 26, 2018

Conversation

Projects
None yet
2 participants
@keith-turner
Contributor

keith-turner commented Apr 26, 2018

No description provided.

@keith-turner keith-turner changed the base branch from master to 1.9 Apr 26, 2018

@ctubbsii

LGTM, but prefer .isEmpty()

@@ -3352,7 +3352,10 @@ private void markUnusedWALs() {
candidates = new HashSet<>(closedLogs);
}
for (Tablet tablet : getOnlineTablets()) {
candidates.removeAll(tablet.getCurrentLogFiles());
tablet.removeInUseLogs(candidates);
if (candidates.size() == 0) {

This comment has been minimized.

@ctubbsii

ctubbsii Apr 26, 2018

Member

Should be isEmpty()?

@ctubbsii ctubbsii merged commit 84791ec into apache:1.9 Apr 26, 2018

0 of 2 checks passed

Jenkins Jenkins is validating pull request ...
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment