From a4f790caca35fdeffdc8772fdf71ce00ecb37351 Mon Sep 17 00:00:00 2001 From: Keith Turner Date: Sat, 11 May 2024 15:19:06 -0400 Subject: [PATCH] ensures instrumented cache is recording stats --- .../java/org/apache/accumulo/tserver/ScanServerMetrics.java | 3 +++ 1 file changed, 3 insertions(+) diff --git a/server/tserver/src/main/java/org/apache/accumulo/tserver/ScanServerMetrics.java b/server/tserver/src/main/java/org/apache/accumulo/tserver/ScanServerMetrics.java index 1a516b597bb..771def8e4ff 100644 --- a/server/tserver/src/main/java/org/apache/accumulo/tserver/ScanServerMetrics.java +++ b/server/tserver/src/main/java/org/apache/accumulo/tserver/ScanServerMetrics.java @@ -23,6 +23,7 @@ import org.apache.accumulo.core.metrics.MetricsProducer; import com.github.benmanes.caffeine.cache.LoadingCache; +import com.google.common.base.Preconditions; import io.micrometer.core.instrument.Counter; import io.micrometer.core.instrument.MeterRegistry; @@ -46,6 +47,8 @@ public void registerMetrics(MeterRegistry registry) { .description("Time to reserve a tablets files for scan").register(registry); busyTimeoutCount = Counter.builder(METRICS_SCAN_BUSY_TIMEOUT_COUNTER) .description("The number of scans where a busy timeout happened").register(registry); + Preconditions.checkState(tabletMetadataCache.policy().isRecordingStats(), + "Attempted to instrument cache that is not recording stats."); CaffeineCacheMetrics.monitor(registry, tabletMetadataCache, METRICS_SCAN_TABLET_METADATA_CACHE); }