Skip to content

Improves accumulo-cluster for start and stop commands #4763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ddanielr merged 10 commits into from
Jul 28, 2024
Merged

Improves accumulo-cluster for start and stop commands #4763

ddanielr merged 10 commits into from
Jul 28, 2024

Conversation

@ddanielr
Copy link
Contributor

@ddanielr ddanielr commented Jul 25, 2024

Adds the ability to start and stop compactors and scan servers by compaction queue or scan server group.

This is important when attempting to run scan servers or compactors and not want to stop/start other accumulo services (gc, monitor, manager, compaction-coordinator).

@ddanielr ddanielr added this to the 2.1.3 milestone Jul 25, 2024
ctubbsii
ctubbsii requested changes Jul 26, 2024
View reviewed changes
@ctubbsii ctubbsii linked an issue Jul 26, 2024 that may be closed by this pull request
Update accumulo-cluster to start and stop compactors #4425
Closed
ddanielr and others added 6 commits July 26, 2024 19:00
@ddanielr @ctubbsii
Update assemble/bin/accumulo-service
6b5280e 
Use local variable for per-file for loop

Co-authored-by: Christopher Tubbs <ctubbsii@apache.org>
@ddanielr
Fix usage statement and standardize logs
912c4dc
@ddanielr
Implement PR feedback
38b01d2
@ddanielr
Revert "Background SSH connections for speed"
81717a2 
This reverts commit 64c38e5.
@ddanielr
Improvements to accumulo-service
0593680 
* switched accumulo-service to mostly using local variables
* start/stop/kill commands now print the name of the process to stdout
@ddanielr
Fix formatting
f99f2bf
@ddanielr
Copy link
Contributor Author

ddanielr commented Jul 27, 2024

One nice side-effect of the accumulo-service refactor is that now the specific service process name is returned to the user, not just the service type:

./accumulo-cluster start-servers --all
...
Starting sserver_default on localhost
Starting compaction-coordinator on localhost
Starting compactor_q1 on localhost
Starting compactor_q2 on localhost

@ddanielr ddanielr mentioned this pull request Jul 27, 2024
Closed
@ddanielr
Copy link
Contributor Author

ddanielr commented Jul 28, 2024

@ctubbsii I believe I've addressed all the changes that were needed.

ctubbsii
ctubbsii reviewed Jul 28, 2024
View reviewed changes
@ddanielr
Fixes var check logic and single brackets
4eb79ec 
Allows ACCUMULO_SERVICE_INSTANCE to be set to an empty string.
Switches from single bracket to double bracket logic to ensure bash
syntax is being used.
@ddanielr ddanielr merged commit ec2f1bd into apache:2.1 Jul 28, 2024
@ddanielr ddanielr deleted the add-compactor-start-stop branch July 28, 2024 20:13
@ddanielr ddanielr mentioned this pull request Jul 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ctubbsii ctubbsii ctubbsii approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.1.3

Development

Successfully merging this pull request may close these issues.

Update accumulo-cluster to start and stop compactors

2 participants

@ddanielr @ctubbsii