Adds constants for threadPool Names#4768
Merged
Merged
Conversation
- updates pool prefix so that pools report as accumulo.pool.... - change names that had names with spaces to use dot notation. - removed metrics from pools where no user provided properties are used
- address PR comments - sort and disable formatting of exceptions in MetricsIT
Create constants for thread pool names to help with metric names and ease of troubleshooting
ddanielr
commented
Jul 26, 2024
ddanielr
commented
Jul 26, 2024
Use the string value stored in the enum vs the default toString output
dlmarion
reviewed
Jul 26, 2024
Refactored the Enum threadpool names to remove the _NAME suffix
Adds constants for the following pools: * Bulk Import Threads * Compaction Service Planner * Tablet wal creator * Scan server tablet metadata cache * Manager upgrade metadata * Compaction Coordinator summary gatherer * Utility check pools
One of the constants was using the same name as the thread pool after the _NAME suffix refactor. Changed the name to eliminate confusion. Sorted the enums based on names and cleaned up formatting
ctubbsii
reviewed
Jul 28, 2024
ctubbsii
reviewed
Jul 28, 2024
ctubbsii
approved these changes
Jul 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contains all of @EdColeman's changes from #4535.
Adds enums for threadpool names so that copy/pasting thread pool names from jstacks should hit on sections of code vs having to search for partial names.