Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Hadoop 3 exclusively for Accumulo 2.0 #531

Merged
merged 1 commit into from Jun 14, 2018

Conversation

@ctubbsii
Copy link
Member

commented Jun 14, 2018

No description provided.

@ctubbsii ctubbsii self-assigned this Jun 14, 2018

@ctubbsii ctubbsii requested a review from joshelser Jun 14, 2018

@ctubbsii

This comment has been minimized.

Copy link
Member Author

commented Jun 14, 2018

I tested this with uno and Hadoop 3.0.2 and it worked fine.

@joshelser

This comment has been minimized.

Copy link
Member

commented Jun 14, 2018

I tested this with uno and Hadoop 3.0.2 and it worked fine.

Have you tried 3.1.0? Last I heard, 3.1.0 is closer to what they'll call "GA" than 3.0.x

@joshelser
Copy link
Member

left a comment

LGTM, hadoop3 version of choice being something that can be considered, but need not be a blocking decision.

@ctubbsii

This comment has been minimized.

Copy link
Member Author

commented Jun 14, 2018

I did not see 3.1.0 on the Hadoop website! I saw 3.0.3 as the latest, but it wouldn't download from Maven, so I dropped back to 3.0.2. I would be happy to try with 3.1.0, though.

@joshelser

This comment has been minimized.

Copy link
Member

commented Jun 14, 2018

Oh, funny. I wonder why that doesn't exist on the website. I didn't think it was a "don't use this" release any more than 3.0.x was...

@ctubbsii

This comment has been minimized.

Copy link
Member Author

commented Jun 14, 2018

I found it. It was further down on the list.

@ctubbsii

This comment has been minimized.

Copy link
Member Author

commented Jun 14, 2018

3.1.0 seems to have problems with resource utilization on my laptop... I'm not able to get it to run, but I'll try on a beefier machine another time.

@ctubbsii ctubbsii merged commit ff8c875 into apache:master Jun 14, 2018

2 checks passed

Jenkins This pull request looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ctubbsii ctubbsii deleted the ctubbsii:hadoop3 branch Jun 14, 2018

@mikewalch

This comment has been minimized.

Copy link
Member

commented Jun 15, 2018

What happens if a user tries to use Accumulo 2.0 with Hadoop 2.x? If there isn't a proper error message currently, I think it would be good to create an issue.

@ctubbsii

This comment has been minimized.

Copy link
Member Author

commented Jun 15, 2018

@mikewalch We're not banning the use of Hadoop 2.x... we're just changing the build and testing to expect it by default. It's possible it will still work... if the user deploys it with an appropriate class path (in fact, it definitely still works now). This isn't about forcing users to use a particular version... it's just about what we're focusing our support around.

Similarly, we wouldn't give an error message if a user used log4j 1.2.15, even though we're using 1.2.17; I don't think we should give an error message here, either.

@mikewalch

This comment has been minimized.

Copy link
Member

commented Jun 15, 2018

@ctubbsii, sounds good to me. I thought this PR meant Hadoop 2.x would not work in the future. I didn't want users to get weird errors and not know it was due to using Hadoop 2.x. If it "works" but it isn't officially supported, that works for me.

asfgit pushed a commit that referenced this pull request Jun 20, 2018

Clean up warnings from #531
Use FileStatus object directly to check if a path is a directory or file

@ctubbsii ctubbsii added this to Done in 2.0.0 Jun 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
3 participants
You can’t perform that action at this time.