Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct display of BulkImport duration in monitor #553

Merged
merged 2 commits into from Jul 6, 2018

Conversation

Projects
None yet
2 participants
@EdColeman
Copy link
Contributor

EdColeman commented Jul 6, 2018

The formatting for monitor display accepts milliseconds. This
fix corrects issue where seconds (duration / 1000) were used,
causing the duration displayed by the monitor to format and display
incorrectly.

ACCUMULO-551 Correct display of BulkImport duration in monitor
The formatting for monitor display accepts milliseconds. This
fix corrects issue where seconds (duration / 1000) were used,
causing the duration displayed by the monitor to format and display
incorrectly.
@ctubbsii

This comment has been minimized.

Copy link
Member

ctubbsii commented Jul 6, 2018

@EdColeman A few helpful things for using GitHub:

  • There is no need to create an issue and a PR if you are creating them at the same time. GitHub PRs are their own issue. Sometimes it's useful to create an issue for future work.
  • It is not necessary to close a PR and create a new one to change the branch. You can click the "Edit" button and select a different branch to do the PR against from the drop-down.
  • When you use the form "ACCUMULO-NNN", it automatically links against the JIRA issue with that ID, and that JIRA issue (such as https://issues.apache.org/jira/browse/ACCUMULO-551) may be completely unrelated. GitHub issues are mentioned using the pound syntax: #551

@ctubbsii ctubbsii changed the title ACCUMULO-551 Correct display of BulkImport duration in monitor Correct display of BulkImport duration in monitor Jul 6, 2018

@ctubbsii ctubbsii added the v1.9.2 label Jul 6, 2018

@ctubbsii

This comment has been minimized.

Copy link
Member

ctubbsii commented Jul 6, 2018

Do you know if a similar issue affects the 2.0 monitor?

@EdColeman

This comment has been minimized.

Copy link
Contributor Author

EdColeman commented Jul 6, 2018

The code for 2.0 has changed such that I do not see the same issue - but I'll need to dig deeper to find the actual display code - a quick look and it seems that milliseconds are being passed around.

@ctubbsii ctubbsii merged commit 2ee5f49 into apache:1.9 Jul 6, 2018

0 of 2 checks passed

Jenkins Jenkins is validating pull request ...
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.