Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix array out of bounds in FastFormat #562

Merged
merged 1 commit into from Jul 17, 2018

Conversation

@keith-turner
Copy link
Contributor

commented Jul 16, 2018

No description provided.

@ctubbsii
Copy link
Member

left a comment

Is this still faster than String.format for padding?

@keith-turner

This comment has been minimized.

Copy link
Contributor Author

commented Jul 17, 2018

Is this still faster than String.format for padding?

I suspect it is, unless something has optimized away parsing and executing the format string each time.

@keith-turner keith-turner merged commit a7aee79 into apache:1.9 Jul 17, 2018

2 checks passed

Jenkins This pull request looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@keith-turner keith-turner deleted the keith-turner:fast-format branch Dec 6, 2018

@ctubbsii ctubbsii added this to Done in 1.9.3 Jun 14, 2019

@ctubbsii ctubbsii added this to Done in 2.0.0 Jun 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.