From 8dd0734cba0eb0fb7014a5e15620e7f513a36bc6 Mon Sep 17 00:00:00 2001 From: Keith Turner Date: Thu, 23 Apr 2026 14:37:12 +0000 Subject: [PATCH 1/3] fixes bug with rpc bind address Fixes two problems. The scripts were using a deprecated rpc bind address property. The server side code was ignoring the deprecated property. --- assemble/bin/accumulo-cluster | 4 ++-- .../main/java/org/apache/accumulo/server/AbstractServer.java | 4 +++- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/assemble/bin/accumulo-cluster b/assemble/bin/accumulo-cluster index 0b3126ce01e..7b065ecb01f 100755 --- a/assemble/bin/accumulo-cluster +++ b/assemble/bin/accumulo-cluster @@ -408,9 +408,9 @@ function execute_command() { servers_per_host="${!S:-1}" if [[ $ARG_LOCAL == 1 ]]; then - debugOrRunAsync bash -c "ACCUMULO_CLUSTER_ARG=$servers_per_host \"$bin/accumulo-service\" $service $control_cmd -o general.process.bind.addr=$host $*" + debugOrRunAsync bash -c "ACCUMULO_CLUSTER_ARG=$servers_per_host \"$bin/accumulo-service\" $service $control_cmd -o rpc.bind.addr=$host $*" else - debugOrRunAsync "${SSH[@]}" "$host" "bash -c 'ACCUMULO_CLUSTER_ARG=$servers_per_host \"$bin/accumulo-service\" $service $control_cmd -o general.process.bind.addr=$host $*'" + debugOrRunAsync "${SSH[@]}" "$host" "bash -c 'ACCUMULO_CLUSTER_ARG=$servers_per_host \"$bin/accumulo-service\" $service $control_cmd -o rpc.bind.addr=$host $*'" fi } diff --git a/server/base/src/main/java/org/apache/accumulo/server/AbstractServer.java b/server/base/src/main/java/org/apache/accumulo/server/AbstractServer.java index 1cadeabaa33..b2e66791e70 100644 --- a/server/base/src/main/java/org/apache/accumulo/server/AbstractServer.java +++ b/server/base/src/main/java/org/apache/accumulo/server/AbstractServer.java @@ -99,6 +99,7 @@ public static void startServer(AbstractServer server, Logger LOG) throws Excepti private final AtomicBoolean closed = new AtomicBoolean(false); private final Set monitorMetricExclusions; + @SuppressWarnings("deprecation") protected AbstractServer(ServerId.Type serverType, ServerOpts opts, BiFunction serverContextFactory, String[] args) { @@ -106,7 +107,8 @@ protected AbstractServer(ServerId.Type serverType, ServerOpts opts, this.applicationName = serverType.name(); opts.parseArgs(applicationName, args); var siteConfig = opts.getSiteConfiguration(); - final String newBindParameter = siteConfig.get(Property.RPC_PROCESS_BIND_ADDRESS); + final String newBindParameter = siteConfig.get(siteConfig + .resolve(Property.RPC_PROCESS_BIND_ADDRESS, Property.GENERAL_PROCESS_BIND_ADDRESS)); // If new bind parameter passed on command line or in file, then use it. if (newBindParameter != null && !newBindParameter.equals(Property.RPC_PROCESS_BIND_ADDRESS.getDefaultValue())) { From 8136192046abaa4e259efcd322e5d1bbcfec21c2 Mon Sep 17 00:00:00 2001 From: Keith Turner Date: Thu, 23 Apr 2026 11:54:24 -0400 Subject: [PATCH 2/3] Update server/base/src/main/java/org/apache/accumulo/server/AbstractServer.java Co-authored-by: Daniel Roberts --- .../main/java/org/apache/accumulo/server/AbstractServer.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/base/src/main/java/org/apache/accumulo/server/AbstractServer.java b/server/base/src/main/java/org/apache/accumulo/server/AbstractServer.java index b2e66791e70..f7575a1e8a3 100644 --- a/server/base/src/main/java/org/apache/accumulo/server/AbstractServer.java +++ b/server/base/src/main/java/org/apache/accumulo/server/AbstractServer.java @@ -111,7 +111,7 @@ protected AbstractServer(ServerId.Type serverType, ServerOpts opts, .resolve(Property.RPC_PROCESS_BIND_ADDRESS, Property.GENERAL_PROCESS_BIND_ADDRESS)); // If new bind parameter passed on command line or in file, then use it. if (newBindParameter != null - && !newBindParameter.equals(Property.RPC_PROCESS_BIND_ADDRESS.getDefaultValue())) { + && !newBindParameter.isBlank() this.bindAddress = newBindParameter; } else { this.bindAddress = ServerOpts.BIND_ALL_ADDRESSES; From b27193c08d8289d28a48bebf99691bed19ee2b41 Mon Sep 17 00:00:00 2001 From: Keith Turner Date: Thu, 23 Apr 2026 16:07:58 +0000 Subject: [PATCH 3/3] code review update --- .../src/main/java/org/apache/accumulo/core/cli/ServerOpts.java | 2 +- .../main/java/org/apache/accumulo/server/AbstractServer.java | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/core/src/main/java/org/apache/accumulo/core/cli/ServerOpts.java b/core/src/main/java/org/apache/accumulo/core/cli/ServerOpts.java index 0158fb4126a..4d8b39e191a 100644 --- a/core/src/main/java/org/apache/accumulo/core/cli/ServerOpts.java +++ b/core/src/main/java/org/apache/accumulo/core/cli/ServerOpts.java @@ -49,7 +49,7 @@ public List split(String value) { description = "Overrides configuration set in accumulo.properties (but NOT system-wide config" + " set in Zookeeper). This is useful when you have process specific configuration items" + " that are one-offs from a shared common configuration. Setting the bind address," - + " for example, can be done with the arguments \"-o general.process.bind.addr=127.0.0.1\"." + + " for example, can be done with the arguments \"-o rpc.bind.addr=127.0.0.1\"." + " Expected format: -o = [-o =]") private List overrides = new ArrayList<>(); diff --git a/server/base/src/main/java/org/apache/accumulo/server/AbstractServer.java b/server/base/src/main/java/org/apache/accumulo/server/AbstractServer.java index f7575a1e8a3..321f09d429e 100644 --- a/server/base/src/main/java/org/apache/accumulo/server/AbstractServer.java +++ b/server/base/src/main/java/org/apache/accumulo/server/AbstractServer.java @@ -110,8 +110,7 @@ protected AbstractServer(ServerId.Type serverType, ServerOpts opts, final String newBindParameter = siteConfig.get(siteConfig .resolve(Property.RPC_PROCESS_BIND_ADDRESS, Property.GENERAL_PROCESS_BIND_ADDRESS)); // If new bind parameter passed on command line or in file, then use it. - if (newBindParameter != null - && !newBindParameter.isBlank() + if (newBindParameter != null && !newBindParameter.isBlank()) { this.bindAddress = newBindParameter; } else { this.bindAddress = ServerOpts.BIND_ALL_ADDRESSES;