Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #767 correct allocation issue in native maps #769

Merged
merged 1 commit into from Nov 15, 2018

Conversation

@keith-turner
Copy link
Contributor

commented Nov 15, 2018

This fixes a bug that was found when building the native maps against
Fedora 29. The cause of the bug was that an empty C++ map seemed to
allocate a small amount of memory, which was a new behavior. This new
behavior violated an assumption made by the custom alloctor used by the
native map code. The code was restructured to avoid this issue.

fixes #767 correct allocation issue in native maps
This fixes a bug that was found when building the native maps against
Fedora 29.  The cause of the bug was that an empty C++ map seemed to
allocate a small amount of memory, which was a new behavior.  This new
behavior violated an assumption made by the custom alloctor used by the
native map code.  The code was restructured to avoid this issue.
@ctubbsii
Copy link
Member

left a comment

Tested on Fedora 29, with gcc-c++-8.2.1-5.fc29.x86_64 and works great on both 1.9 and master branch.

@ctubbsii ctubbsii merged commit df1061b into apache:1.9 Nov 15, 2018

2 checks passed

Jenkins This pull request looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@keith-turner keith-turner deleted the keith-turner:accumulo-767 branch Dec 6, 2018

@ctubbsii ctubbsii added this to Done in 1.9.3 Jun 14, 2019

@ctubbsii ctubbsii added this to Done in 2.0.0 Jun 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.