Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support running MiniAccumuloCluster using Java 11 #942

Closed
wants to merge 1 commit into from

Conversation

@mikewalch
Copy link
Member

commented Feb 7, 2019

} else {
log.debug("Using classpath set by java.class.path system property: {}", javaClassPath);
}
classpathBuilder.append(File.pathSeparator).append(javaClassPath);

This comment has been minimized.

Copy link
@ctubbsii

ctubbsii Feb 7, 2019

Member

+1; I wonder if we should always do this, even in the case of a URLClassLoader (above). It's so simple, and we don't even need to care at all about what kind of class loader the system class loader is using (although, we are assuming the environment is set... so if a system class loader doesn't use that, the user would have to set it explicitly... but that's fine.)

This comment has been minimized.

Copy link
@mikewalch

mikewalch Feb 7, 2019

Author Member

I am going to put this change in 1.9 & 2.0 and then I will follow up with a new PR that simplifies it for 2.0

@keith-turner

This comment has been minimized.

Copy link
Contributor

commented Feb 7, 2019

Would be nice to make this change for 1.9

@ctubbsii ctubbsii added v2.0.0 labels Feb 7, 2019

@mikewalch

This comment has been minimized.

Copy link
Member Author

commented Feb 7, 2019

I merged this pull request with the commit 61c4491 but I referenced #924 by accident instead of #942 in the commit message.

@mikewalch mikewalch closed this Feb 7, 2019

@mikewalch mikewalch deleted the mikewalch:java-11-mini branch Feb 7, 2019

@ctubbsii ctubbsii added this to In Progress in Feature: Java 11 via automation Jun 11, 2019

@ctubbsii ctubbsii moved this from In Progress to Done in Feature: Java 11 Jun 11, 2019

@ctubbsii ctubbsii added this to Done in 1.9.3 Jun 14, 2019

@ctubbsii ctubbsii added this to Done in 2.0.0 Jun 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
3 participants
You can’t perform that action at this time.