From e4276e8cd0b86445da4209dab720b4251300682a Mon Sep 17 00:00:00 2001 From: Clebert Suconic Date: Fri, 24 Sep 2021 13:16:56 -0400 Subject: [PATCH] NO-JIRA Update Paging Logging with extra information --- .../core/paging/cursor/impl/PageSubscriptionImpl.java | 5 ++++- .../activemq/artemis/core/server/ActiveMQServerLogger.java | 4 ++-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageSubscriptionImpl.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageSubscriptionImpl.java index a009ed177d3..5178096735a 100644 --- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageSubscriptionImpl.java +++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageSubscriptionImpl.java @@ -920,7 +920,10 @@ public void processReload() throws Exception { } if (cache == null || pos.getMessageNr() >= 0 && cache.getMessage(pos) == null) { - ActiveMQServerLogger.LOGGER.pageNotFound(pos); + try { + ActiveMQServerLogger.LOGGER.pageNotFound(pos, this.cursorId, this.queue.getName().toString()); + } catch (Throwable ignored) { + } if (txDeleteCursorOnReload == -1) { txDeleteCursorOnReload = store.generateID(); } diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ActiveMQServerLogger.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ActiveMQServerLogger.java index fa41d450e93..0cfae2ad38e 100644 --- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ActiveMQServerLogger.java +++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ActiveMQServerLogger.java @@ -571,9 +571,9 @@ void slowConsumerDetected(String sessionID, void timedOutFlushingExecutorsPagingCursor(PageSubscription pageSubscription); @LogMessage(level = Logger.Level.WARN) - @Message(id = 222028, value = "Could not find page cache for page {0} removing it from the journal", + @Message(id = 222028, value = "Could not find page cache for page {0}, on queue {1}/{2} removing it from the journal", format = Message.Format.MESSAGE_FORMAT) - void pageNotFound(PagePosition pos); + void pageNotFound(PagePosition pos, long queueID, String queue); @LogMessage(level = Logger.Level.WARN) @Message(id = 222029,