ARTEMIS-1268 Fix LargeMessages over STOMP #1394
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -389,7 +389,7 @@ public void sendInternalLarge(CoreMessage message, boolean direct) throws Except | |||
| long id = storageManager.generateID(); | |||
| LargeServerMessage largeMessage = storageManager.createLargeMessage(id, message); | |||
|
|
|||
| byte[] bytes = new byte[message.getBodyBuffer().writerIndex() - CoreMessage.BODY_OFFSET]; | |||
| byte[] bytes = new byte[message.getBodyBuffer().readableBytes()]; | |||
There was a problem hiding this comment.
getReadOnlyBuffer() ???
you would need to cache the bodyBuffer somewhere.. bodyBuffer = message.getReadONlyBuffer();
and only use the bodyBuffer.
There was a problem hiding this comment.
it would be safer to do it this way.. I'm sure it wouldn't affect other messages..
message.getBodyBuffer() may affect the position of a message if it's on a topic with many subscriptions.
There was a problem hiding this comment.
@clebertsuconic yes. Will change. Cheers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.