New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA: Sync OSGi broker config with latest changes from ARTEMIS-1628 #1863

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@graben
Contributor

graben commented Feb 11, 2018

No description provided.

@@ -32,21 +32,23 @@ under the License.
MAPPED: mmap files
NIO: Plain Java Files
-->
<journal-type>ASYNCIO</journal-type>
<journal-type>NIO</journal-type>

This comment has been minimized.

@michaelandrepearce

michaelandrepearce Feb 12, 2018

Contributor

ASYNCIO should be the default it’s more performant and Artemis will fall back to NIO if not present

This comment has been minimized.

@graben

graben Feb 12, 2018

Contributor

Well, I synced with a created default broker.xml its default is actually NIO and avoid "urgly" comments on every broker start if asyncio is not supported

<paging-directory>./data/artemis/paging</paging-directory>
<paging-directory>./paging</paging-directory>

This comment has been minimized.

@michaelandrepearce

michaelandrepearce Feb 12, 2018

Contributor

Why change this?

This comment has been minimized.

@graben

graben Feb 12, 2018

Contributor

root directory is data/artemis/. This avoid data/artemis to be used unnecessary twice.

@@ -196,5 +194,20 @@ under the License.
</addresses>
<!-- Uncomment the following if you want to use the Standard LoggingActiveMQServerPlugin pluging to log in events

This comment has been minimized.

@michaelandrepearce

michaelandrepearce Feb 12, 2018

Contributor

Why add this?

This comment has been minimized.

@graben

graben Feb 12, 2018

Contributor

As mentioned before it's coming from default.

@jbertram

This comment has been minimized.

Contributor

jbertram commented Feb 12, 2018

Is there no option to just copy (or build) this file from the source so manual syncing isn't necessary?

@graben

This comment has been minimized.

Contributor

graben commented Feb 12, 2018

Well, actually the broker.xml is build from several templates and snippets. OSGi needs a complete file to trigger broker deployment. Therefore a a file need to be constructed during build process. Meight be tricky.

@graben

This comment has been minimized.

Contributor

graben commented Feb 16, 2018

Any further objection to not merge this?

@asfgit asfgit closed this in 8dfa345 Feb 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment