Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARTEMIS-1825 Live-backup topology not correctly displayed on console #2041

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@gaohoward
Copy link
Contributor

commented Apr 24, 2018

No description provided.

var newBackReq = ARTEMISService.artemisConsole.isBackup(jolokia, mBean);
var newBackup = newBackReq.value;
if (!newBackup) {
ARTEMIS.log.info("yes I'm master right now");

This comment has been minimized.

Copy link
@clebertsuconic

clebertsuconic Apr 25, 2018

Contributor

this is a debug message.. you probably didn't mean to have it here.

}
}
else {
ARTEMIS.log.info("ok I'm backup!");

This comment has been minimized.

Copy link
@clebertsuconic

clebertsuconic Apr 25, 2018

Contributor

debug message

This comment has been minimized.

Copy link
@gaohoward

gaohoward Apr 26, 2018

Author Contributor

Yes should be debug. I'll change that. Thx.

@gaohoward gaohoward force-pushed the gaohoward:h1825 branch from 8224155 to 52d51f6 Apr 26, 2018

@gaohoward

This comment has been minimized.

Copy link
Contributor Author

commented Apr 26, 2018

var newBackReq = ARTEMISService.artemisConsole.isBackup(jolokia, mBean);
var newBackup = newBackReq.value;
if (!newBackup) {
ARTEMIS.log.debug("yes I'm master right now");

This comment has been minimized.

Copy link
@clebertsuconic

clebertsuconic Apr 26, 2018

Contributor

You still have unintended debug messages here

@gaohoward gaohoward force-pushed the gaohoward:h1825 branch from 52d51f6 to d04a095 Apr 26, 2018

@gaohoward

This comment has been minimized.

Copy link
Contributor Author

commented Apr 26, 2018

@clebertsuconic removed the debug logs.

@clebertsuconic

This comment has been minimized.

Copy link
Contributor

commented May 3, 2018

@mtaylor / @andytaylor / @michaelandrepearce I didn't work on this module a lot... can you guys check on this?

@asfgit asfgit force-pushed the apache:master branch from 99fbfc4 to 2748ef0 Jul 17, 2018

@michaelandrepearce

This comment has been minimized.

Copy link
Contributor

commented Nov 9, 2018

@gaohoward sorry taken a while to look at this as have been burning hours on other issue. From what i can tell from the JS this looks ok, i assume form reading the js, the idea here is more clearly show who is live and who is a slave, calling a method to deduce this, rather than the hardcoded master=true, is this roughly a correct understanding? If so +1 from me.

@gaohoward

This comment has been minimized.

Copy link
Contributor Author

commented Nov 9, 2018

@michaelandrepearce Yes that's the idea.

@michaelandrepearce

This comment has been minimized.

Copy link
Contributor

commented Nov 9, 2018

Great ill merge this shortly then. Thanks for the contribution, and sorry again for taking soo long to review it

@gaohoward

This comment has been minimized.

Copy link
Contributor Author

commented Nov 9, 2018

np at all.

@asfgit asfgit closed this in b3e767c Nov 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.