Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARTEMIS-1916 Remove Jmx ArtemisRMIServerSocketFactory #2128

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@gaohoward
Copy link
Contributor

commented Jun 7, 2018

The ArtemisRMIServerSocketFactory doesn't do anything special,
instead the existence of this impl class causes jmx client
failed to connect (for reason not known, probably not fully
implemented the functionality). It turns out just fine
to use JDK's impl. This class is not necessary.

ARTEMIS-1916 Remove Jmx ArtemisRMIServerSocketFactory
The ArtemisRMIServerSocketFactory doesn't do anything special,
instead the existence of this impl class causes jmx client
failed to connect (for reason not known, probably not fully
implemented the functionality). It turns out just fine
to use JDK's impl. This class is not necessary.
@clebertsuconic

This comment has been minimized.

Copy link
Contributor

commented Jun 7, 2018

You have 2 PRs open for JMX why not use a single one?

@gaohoward

This comment has been minimized.

Copy link
Contributor Author

commented Jun 7, 2018

@clebertsuconic I split it because Martyn suggested that this doesn't belong to a test PR. (see Martyn's comment)

@andytaylor

This comment has been minimized.

Copy link
Contributor

commented Jun 11, 2018

I would create a single PR.

Also Im not sure this is a complete fix. There is still code in there that sets up an SSL socket layer.

Also I think we need to understand why the code as is doesn't work

@gaohoward

This comment has been minimized.

Copy link
Contributor Author

commented Jul 5, 2018

Closing this PR as it's a non issue.

@gaohoward gaohoward closed this Jul 5, 2018

@gaohoward gaohoward deleted the gaohoward:b_artemis1916 branch Jul 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.