Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARTEMIS-2130 - This is to allow views to have the client id when set … #2465

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
2 participants
@andytaylor
Copy link
Contributor

commented Dec 14, 2018

@andytaylor

This comment has been minimized.

Copy link
Contributor Author

commented Dec 14, 2018

when the core protocol is used the client is not available in the connection, via jmx or console, because it is set on the connecting session. This adds this info at the view level. I couldnt find a better way to do this

@jbertram

This comment has been minimized.

Copy link
Contributor

commented Dec 14, 2018

Could there just be a column where we dump all the session metadata?

@andytaylor

This comment has been minimized.

Copy link
Contributor Author

commented Dec 14, 2018

The thing is we have a place for client id, the other protocols use this

@jbertram

This comment has been minimized.

Copy link
Contributor

commented Dec 14, 2018

This does appear to be the simplest solution to a complex issue. Could you use the org.apache.activemq.artemis.jms.client.ActiveMQConnection#JMS_SESSION_CLIENT_ID_PROPERTY constant instead of straight "jms-client-id"? You'll need to add a new dependency on the artemis-server pom.xml for artemis-jms-client.

@asfgit asfgit closed this in 3feba1e Dec 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.