Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for alerts from lgtm.com #2470

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
3 participants
@jbertram
Copy link
Contributor

jbertram commented Dec 18, 2018

After reviewing lgtm.com based on #2290 I decided to fix a handful of the warnings and errors they reported.

@jbertram jbertram force-pushed the jbertram:lgtm branch from e71ff08 to b1d8b86 Dec 18, 2018

@@ -216,63 +216,63 @@ private static void printPages(DescribeJournal describeJournal,

if (pgStore != null) {
folder = pgStore.getFolder();

This comment has been minimized.

Copy link
@clebertsuconic

clebertsuconic Dec 19, 2018

Contributor

There's a semantic change here, are you sure?

This comment has been minimized.

Copy link
@jbertram

jbertram Dec 19, 2018

Author Contributor

The not-null check here on pgStore indicates that pgStore may, in fact, be null. If it is null then it will trigger a NullPointerException almost straight away.

@clebertsuconic

This comment has been minimized.

Copy link
Contributor

clebertsuconic commented Dec 19, 2018

all lgtm, pun intended

If we could run the full testsuite just to be sure.

@michaelandrepearce

This comment has been minimized.

Copy link
Contributor

michaelandrepearce commented Jan 4, 2019

+1 from me, nice!

@asfgit asfgit closed this in ba53bed Jan 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.