New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc. fixes #257

Open
wants to merge 10 commits into
base: master
from

Fix inconsistent 'info'-level logger calls

Some calls to info() were guarded by checks that logging at the trace
level is enabled.

These issues were found by SLF4J Helper for NetBeans IDE:
http://plugins.netbeans.org/plugin/72557/
  • Loading branch information...
Daniel Trebbien
Daniel Trebbien committed Jul 29, 2017
commit 1ec6bfe9f671415f971af1d8b435bd7ba902cf3d
@@ -199,7 +199,7 @@ private PersistenceAdapter getMatchingPersistenceAdapter(ActiveMQDestination des
if (filteredAdapter.getDestination() == matchAll && filteredAdapter.isPerDestination()) {
filteredAdapter = addAdapter(filteredAdapter, destination);
if (LOG.isTraceEnabled()) {
LOG.info("created per destination adapter for: " + destination + ", " + result);
LOG.trace("created per destination adapter for: " + destination + ", " + result);
}
}
startAdapter(filteredAdapter.getPersistenceAdapter(), destination.getQualifiedName());
@@ -331,11 +331,11 @@ private void removeMessageStore(PersistenceAdapter adapter, ActiveMQDestination
if (adapterDir != null) {
if (IOHelper.deleteFile(adapterDir)) {
if (LOG.isTraceEnabled()) {
LOG.info("deleted per destination adapter directory for: " + destination);
LOG.trace("deleted per destination adapter directory for: " + destination);
}
} else {
if (LOG.isTraceEnabled()) {
LOG.info("failed to deleted per destination adapter directory for: " + destination);
LOG.trace("failed to deleted per destination adapter directory for: " + destination);
}
}
}
ProTip! Use n and p to navigate between commits in a pull request.