Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PGA Enhancements and Bug Fixes #58

Merged
merged 7 commits into from Jul 2, 2017

Conversation

Projects
None yet
3 participants
@tilaks26
Copy link

commented Jun 30, 2017

This PR is created for all the changes made to the PGA portal. The following issues were fixed -

[AIRAVATA-2385] - Portal checks for Gateway requests with the same name or URL as that of an already approved/created/deployed Gateway.
[AIRAVATA-2463] - The portal now accepts duplicate Gateway requests.
[AIRAVATA-2199] - The modified flow includes the following states: REQUESTED (when a new Gateway is requested), APPROVED (when a Gateway is approved by the Admin), DENIED (when a Gateway is denied by the Admin), CREATED (when the Gateway details have been filled and the Admin chooses to create a Tenant), DEPLOYED (when the SciGaP Admin deploys a Gateway after which the provider can use it), DEACTIVATED (when the Gateway is no longer in use).
[AIRAVATA-2325] - The auth keys are generated only when the Admin chooses to create the tenant.
[AIRAVATA-2199] - The Gateway status changes to APPROVED when the Admin approves the request and CREATED when the Admin created the tenant.
[AIRAVATA-2079] - An email is sent to the Admin every time a user requests for a new Gateway. Also, an email is sent to the Gateway Provider and Admin when ever there is a change or update in the Gateway details.
[AIRAVATA-2046] - The Admin can edit the gateway request until the tenant is created.
[AIRAVATA-2022] - When a new Gateway is requested, the message displayed is "Your request for Gateway has been created."
[AIRAVATA-2404] - When the Admin creates a tenant, the IAMAdminServices's setUpGateway() method is invoked which then generated the Keycloak secret keys.
[AIRAVATA-2446] - The request for a new Gateway now asks for minimal information which includes the Gateway Name, Contact Email ID and Public Project Description. Once approved by the Admin, the provider can update the other details through a form.
[AIRAVATA-1989] - The 'Add a new Gateway' button on the Admin's portal now redirects to a standalone new form where the Admin can create a new Gateway which directly goes into the APPROVED state.

Since there were many changes to be made with respect to the PGA, I have created just one PR with all the changes.

@machristie
Copy link
Contributor

left a comment

Looks good Sneha. I have a couple of comments, but overall it looks good.

@@ -0,0 +1,70 @@
<?php
class UpdateController extends BaseController

This comment has been minimized.

Copy link
@machristie

machristie Jun 30, 2017

Contributor

Can we call this GatewayRequestUpdateController or something?

This comment has been minimized.

Copy link
@tilaks26

tilaks26 Jun 30, 2017

Author

Sure, Marcus.

public static function update_gateway( $gatewayId, $gatewayData){
$gateway = Airavata::getGateway( Session::get('authz-token'), $gatewayId);
$gateway = TenantProfileService::getGateway( Session::get('authz-token'), $gatewayId);

This comment has been minimized.

Copy link
@machristie

machristie Jun 30, 2017

Contributor

I don't think this will work to get a gateway by gatewayId and then update it, when it is possible for multiple gateways to have the same id. I think we need a backend method to get a gateway by the internal id. What do you think? I can add it.

This comment has been minimized.

Copy link
@machristie

machristie Jun 30, 2017

Contributor

Also I think we can go ahead and merge this pull request and fix this after.

@asfgit asfgit merged commit d774332 into apache:develop Jul 2, 2017

asfgit pushed a commit that referenced this pull request Jul 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.