refactor: flatten the sharing packages into the iam namespace#647
Merged
Conversation
Now that the sharing code lives in iam-service, collapse its org.apache.airavata.sharing.{config,event,grpc,model,repository,service,util} Java packages into the matching org.apache.airavata.iam.* packages so the module has a single coherent namespace. This is an internal, server-side-only move: the proto packages (org.apache.airavata.api.sharing / .groupmanager) and the shared org.apache.airavata.sharing.registry.models.proto types are deliberately left untouched, and every external reference to sharing went through those proto/facade types, so no consumer import or gRPC/REST wire contract changes. The redundant SharingServiceConfig is removed because IamServiceConfig already component- and entity-scans org.apache.airavata.iam, which now covers the moved beans and entities. The one name clash — two different AbstractRepository base classes — is resolved by renaming the entity-direct sharing base to AbstractSharingRepository; it has a different type arity and a checked-exception contract than iam's model-converting AbstractRepository, so the two are kept distinct rather than force-merged. The full reactor builds green and iam-service tests (including the relocated ResourceSharingServiceTest) pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that the sharing code lives in
iam-service, this collapses itsorg.apache.airavata.sharing.{config,event,grpc,model,repository,service,util}Java packages into the matchingorg.apache.airavata.iam.*packages so the module has a single coherent namespace. It is an internal, server-side-only move: the proto packages (org.apache.airavata.api.sharing/.groupmanager) and the sharedorg.apache.airavata.sharing.registry.models.prototypes are deliberately left untouched, and every external reference to sharing went through those proto/facade types, so there is no consumer import or gRPC/REST wire-contract change. The redundantSharingServiceConfigis removed becauseIamServiceConfigalready component- and entity-scansorg.apache.airavata.iam, which now covers the moved beans and entities. The one name clash — two differentAbstractRepositorybase classes — is resolved by renaming the entity-direct sharing base toAbstractSharingRepository; it has a different type arity and a checked-exception contract than iam's model-convertingAbstractRepository, so the two are kept distinct rather than force-merged. The full reactor builds green and iam-service tests (including the relocatedResourceSharingServiceTest) pass.A follow-up PR will nest the proto packages under
api.iam.*(wire-breaking; includes Python SDK regeneration).