fix(storage-service): delete files over SFTP instead of shell rm#654
Merged
Conversation
UserStorageService.deleteFile ran "rm -f <path>" via adaptor.executeCommand, but the SFTP storage adaptor does not support command execution, so every file delete failed with "Command execution not supported on storage resources". Add a deleteFile to the storage adaptor (SFTP rm) and call it, mirroring how deleteDir already uses deleteDirectory (SFTP rmdir). Validated live: uploading then deleting a file now succeeds (the file is gone).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UserStorageService.deleteFile ran 'rm -f' via executeCommand, which the SFTP storage adaptor doesn't support, so every user-storage file delete failed with 'Command execution not supported on storage resources'. Add SSHJStorageAdaptor.deleteFile (SFTP remove) to the StorageResourceAdaptor interface and call it from deleteFile, mirroring how deleteDir already uses the adaptor's rmdir. Verified live: upload -> delete round-trips.