fix(storage-service): move/symlink over SFTP instead of shell commands#655
Merged
Merged
Conversation
UserStorageService.moveFile and createSymlink ran "mv"/"ln -s" via adaptor.executeCommand, which the SFTP storage adaptor does not support, so both failed with "Command execution not supported on storage resources" (the same class of bug just fixed for deleteFile). Add moveFile (SFTP rename) and createSymlink (SFTP symlink) to the storage adaptor and call them. Validated live: moving a file relocates it (source gone, destination has the content); creating a symlink to a directory resolves through the link (listing the link shows the target's contents). storage + compute unit tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UserStorageService.moveFileandcreateSymlinkranmv/ln -sviaadaptor.executeCommand, but the SFTP storage adaptor does not support command execution, so both failed with "Command execution not supported on storage resources" — the same class of bug just fixed fordeleteFile(#654). AddmoveFile(SFTPrename) andcreateSymlink(SFTPsymlink) to the storage adaptor and call them.Validation
mvn test -pl airavata-api/storage-service,airavata-api/compute-service→ 35 pass, 0 failures.