ci(tests): add privacy-llm checker and redactor to pytest matrix#59
Merged
Merged
Conversation
The two privacy-llm Python packages (checker: 33 tests, redactor: 48 tests) were omitted from the CI pytest matrix despite having passing test suites and their own pyproject.toml + uv.lock. This brings the visible CI signal in line with the actual test surface. Signed-off-by: André Ahlert <andre@aex.partners>
Member
|
😱 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The CI pytest matrix in
.github/workflows/tests.ymlcurrently exercises three Python projects:tools/gmail/oauth-drafttools/vulnogram/generate-cve-jsontools/skill-validatorTwo additional projects under
tools/privacy-llm/have full test suites but are not in the matrix:checkerredactorThis means regressions in privacy-llm code would not be caught by the visible CI signal (the
tests.ymlworkflow). Theprekworkflow does exercise pytest as a hook, but the per-project matrix intests.ymlis the triage-friendly surface that shows green/red per package in the PR checks list.What changes
.github/workflows/tests.yml— adds two entries to thematrix.projectlist:name: privacy-llm-checker,path: tools/privacy-llm/checkername: privacy-llm-redactor,path: tools/privacy-llm/redactorVerification
uv run --directory tools/privacy-llm/checker --group dev pytest --color=yes→ 33 passeduv run --directory tools/privacy-llm/redactor --group dev pytest --color=yes→ 48 passedprek run --all-filespasses with the workflow YAML change (markdownlint + yamllint implicit via prek hooks).Impact
privacy-llm-checkerandprivacy-llm-redactor, matching the actual test surface.