From 413e364f07e49ac6792fee72cb02ebda8a64c029 Mon Sep 17 00:00:00 2001 From: Albert Olweny <41315252+okirialbert@users.noreply.github.com> Date: Tue, 27 Feb 2024 15:24:43 +0300 Subject: [PATCH] Add missing test for cli triggerer command (#37743) * increase code coverage for cli triggerer_command * unused import --- scripts/cov/cli_coverage.py | 1 - tests/cli/commands/test_triggerer_command.py | 13 +++++++++++++ 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/scripts/cov/cli_coverage.py b/scripts/cov/cli_coverage.py index 4afe2a8c86f70..043010676ff45 100644 --- a/scripts/cov/cli_coverage.py +++ b/scripts/cov/cli_coverage.py @@ -46,7 +46,6 @@ "airflow/cli/commands/scheduler_command.py", "airflow/cli/commands/standalone_command.py", "airflow/cli/commands/task_command.py", - "airflow/cli/commands/triggerer_command.py", "airflow/cli/commands/variable_command.py", "airflow/cli/commands/webserver_command.py", "airflow/cli/simple_table.py", diff --git a/tests/cli/commands/test_triggerer_command.py b/tests/cli/commands/test_triggerer_command.py index abfba226758ac..b5222038f2de5 100644 --- a/tests/cli/commands/test_triggerer_command.py +++ b/tests/cli/commands/test_triggerer_command.py @@ -50,3 +50,16 @@ def test_capacity_argument( mock_serve.return_value.__enter__.assert_called_once() mock_serve.return_value.__exit__.assert_called_once() mock_triggerer_job_runner.assert_called_once_with(job=mock.ANY, capacity=42) + + @mock.patch("airflow.cli.commands.triggerer_command.TriggererJobRunner") + @mock.patch("airflow.cli.commands.triggerer_command.run_job") + @mock.patch("airflow.cli.commands.triggerer_command.Process") + def test_trigger_run_serve_logs(self, mock_process, mock_run_job, mock_trigger_job_runner): + """Ensure that trigger runner and server log functions execute as intended""" + triggerer_command.triggerer_run(False, 1, 10.3) + + mock_process.assert_called_once() + mock_run_job.assert_called_once_with( + job=mock_trigger_job_runner.return_value.job, + execute_callable=mock_trigger_job_runner.return_value._execute, + )