Skip to content
Permalink
Browse files
Cleanup references to selective checks (#24649)
Selective checks docs have been moved to breeze as part of #24610
but some of the references were still left.

This PR cleans it up.
  • Loading branch information
potiuk committed Jun 25, 2022
1 parent 2703874 commit aa8cd30c46dde496423c72aa4a2c72b44d554745
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 13 deletions.
@@ -17,7 +17,6 @@ Dockerfile.ci export-ignore

ISSUE_TRIAGE_PROCESS.rst export-ignore
PULL_REQUEST_WORKFLOW.rst export-ignore
SELECTIVE_CHECKS.md export-ignore
STATIC_CODE_CHECKS.rst export-ignore
TESTING.rst export-ignore
LOCAL_VIRTUALENV.rst export-ignore
@@ -1336,7 +1336,7 @@ needed to run the CI Builds. You can also use the tool to test what tests will b
a specific commit that Breeze should run the tests on.

More details about the algorithm used to pick the right tests can be
found in `Selective Checks <SELECTIVE_CHECKS.md>`_.
found in `Selective Checks <dev/breeze/SELECTIVE_CHECKS.md>`_.

Those are all available flags of ``selective-check`` command:

@@ -43,16 +43,9 @@ We approached the problem by:

2) Heavily decreasing strain on the GitHub Actions jobs by introducing selective checks - mechanism
to control which parts of the tests are run during the tests. This is implemented by the
``scripts/ci/selective_ci_checks.sh`` script in our repository. This script analyses which part of the
code has changed and based on that it sets the right outputs that control which tests are executed in
the ``Tests`` workflow, and whether we need to build CI images necessary to run those steps. This allowed to
heavily decrease the strain especially for the Pull Requests that were not touching code (in which case
the builds can complete in < 2 minutes) but also by limiting the number of tests executed in PRs that do
not touch the "core" of Airflow, or only touching some - standalone - parts of Airflow such as
"Providers", "WWW" or "CLI". This solution is not yet perfect as there are likely some edge cases but
it is easy to maintain and we have an escape-hatch - all the tests are always executed in main pushes,
so contributors can easily spot if there is a "missed" case and fix it - both by fixing the problem and
adding those exceptions to the code. More about it can be found in `Selective checks <SELECTIVE_CHECKS.md>`_
``breeze selective-check`` command. It selectively chooses which tests should be run in the PR based on
type of the PR and its content. More about it can be found in
`Selective checks <dev/breeze/SELECTIVE_CHECKS.md>`_

3) Even more optimisation came from limiting the scope of tests to only "default" matrix parameters. So far
in Airflow we always run all tests for all matrix combinations. The primary matrix components are:
@@ -133,7 +133,6 @@ def is_core_commit(files: List[str]) -> bool:
"BREEZE.rst",
"CI.rst",
"CI_DIAGRAMS.md",
"SELECTIVE_CHECKS.md",
"STATIC_CODE_CHECKS.rst",
"images/",
"TESTING.rst",

0 comments on commit aa8cd30

Please sign in to comment.