From b124d6e94fc4a7cd2cafba4580180788d1716728 Mon Sep 17 00:00:00 2001 From: Albert Olweny <41315252+okirialbert@users.noreply.github.com> Date: Mon, 26 Feb 2024 22:07:55 +0300 Subject: [PATCH] Fix init checks for aws `eks` (#37674) --- .pre-commit-config.yaml | 1 - airflow/providers/amazon/aws/operators/eks.py | 16 ++++++++++++---- 2 files changed, 12 insertions(+), 5 deletions(-) diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 1efa63e75ab1f..321dd2341db98 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -327,7 +327,6 @@ repos: ^.*__init__\.py$| ^airflow\/providers\/amazon\/aws\/transfers\/redshift_to_s3\.py$| ^airflow\/providers\/amazon\/aws\/operators\/emr\.py$| - ^airflow\/providers\/amazon\/aws\/operators\/eks\.py$ )$ - id: ruff name: Run 'ruff' for extremely fast Python linting diff --git a/airflow/providers/amazon/aws/operators/eks.py b/airflow/providers/amazon/aws/operators/eks.py index 7348d08b6f485..60ae181d833da 100644 --- a/airflow/providers/amazon/aws/operators/eks.py +++ b/airflow/providers/amazon/aws/operators/eks.py @@ -246,7 +246,9 @@ def __init__( self.nodegroup_role_arn = nodegroup_role_arn self.fargate_pod_execution_role_arn = fargate_pod_execution_role_arn self.create_fargate_profile_kwargs = create_fargate_profile_kwargs or {} - self.wait_for_completion = False if deferrable else wait_for_completion + if deferrable: + wait_for_completion = False + self.wait_for_completion = wait_for_completion self.waiter_delay = waiter_delay self.waiter_max_attempts = waiter_max_attempts self.aws_conn_id = aws_conn_id @@ -494,7 +496,9 @@ def __init__( self.nodegroup_role_arn = nodegroup_role_arn self.nodegroup_name = nodegroup_name self.create_nodegroup_kwargs = create_nodegroup_kwargs or {} - self.wait_for_completion = False if deferrable else wait_for_completion + if deferrable: + wait_for_completion = False + self.wait_for_completion = wait_for_completion self.aws_conn_id = aws_conn_id self.region = region self.waiter_delay = waiter_delay @@ -616,7 +620,9 @@ def __init__( self.pod_execution_role_arn = pod_execution_role_arn self.fargate_profile_name = fargate_profile_name self.create_fargate_profile_kwargs = create_fargate_profile_kwargs or {} - self.wait_for_completion = False if deferrable else wait_for_completion + if deferrable: + wait_for_completion = False + self.wait_for_completion = wait_for_completion self.aws_conn_id = aws_conn_id self.region = region self.waiter_delay = waiter_delay @@ -715,7 +721,9 @@ def __init__( ) -> None: self.cluster_name = cluster_name self.force_delete_compute = force_delete_compute - self.wait_for_completion = False if deferrable else wait_for_completion + if deferrable: + wait_for_completion = False + self.wait_for_completion = wait_for_completion self.aws_conn_id = aws_conn_id self.region = region self.deferrable = deferrable