From cf5c3c8d02f0089adfcfa3dad9e2580d290251e6 Mon Sep 17 00:00:00 2001 From: Jarek Potiuk Date: Wed, 26 Apr 2023 03:22:50 +0200 Subject: [PATCH] Fix failing trigger test after Flask 2.2.4 upgrade (#30875) Flask 2.2.4 released yesterday, cause one of our (far too picky) tests to break - breaking main. This PR fixes it by making the test less picky. (cherry picked from commit 3f3afe98820b93305d91352fd07a98d6ca54df57) --- tests/www/views/test_views_trigger_dag.py | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/tests/www/views/test_views_trigger_dag.py b/tests/www/views/test_views_trigger_dag.py index 8e3b850491e91..6e793ed0d4cf1 100644 --- a/tests/www/views/test_views_trigger_dag.py +++ b/tests/www/views/test_views_trigger_dag.py @@ -192,13 +192,9 @@ def test_trigger_dag_params_conf(admin_client, request_conf, expected_conf): else: test_request_conf = json.dumps(request_conf, indent=4) resp = admin_client.get(f"trigger?dag_id={test_dag_id}&conf={test_request_conf}&doc_md={doc_md}") - - expected_dag_conf = json.dumps(expected_conf, indent=4).replace('"', """) - - check_content_in_response( - f'', - resp, - ) + for key in expected_conf.keys(): + check_content_in_response(key, resp) + check_content_in_response(str(expected_conf[key]), resp) def test_trigger_dag_params_render(admin_client, dag_maker, session, app, monkeypatch):