Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status of testing Providers that were prepared on August 19, 2024 #41577

Closed
29 of 43 tasks
eladkal opened this issue Aug 19, 2024 · 20 comments
Closed
29 of 43 tasks

Status of testing Providers that were prepared on August 19, 2024 #41577

eladkal opened this issue Aug 19, 2024 · 20 comments
Labels
area:providers kind:meta High-level information important to the community testing status Status of testing releases

Comments

@eladkal
Copy link
Contributor

eladkal commented Aug 19, 2024

Body

I have a kind request for all the contributors to the latest provider packages release.
Could you please help us to test the RC versions of the providers?

The guidelines on how to test providers can be found in

Verify providers by contributors

Let us know in the comment, whether the issue is addressed.

Those are providers that require testing as there were some substantial changes introduced:

Provider amazon: 8.28.0rc1

Provider apache.spark: 4.10.0rc1

Provider celery: 3.8.0rc1

Provider cncf.kubernetes: 8.4.0rc1

Provider common.sql: 1.16.0rc1

Provider docker: 3.13.0rc1

Provider elasticsearch: 5.5.0rc1

Provider fab: 1.3.0rc1

Provider google: 10.22.0rc1

Provider microsoft.azure: 10.4.0rc1

Provider microsoft.mssql: 3.9.0rc1

Provider openlineage: 1.11.0rc1

Provider papermill: 3.8.0rc1

Provider snowflake: 5.7.0rc1

Provider yandex: 3.12.0rc1

Provider ydb: 1.3.0rc1

All users involved in the PRs:
@morokosi @mobuchowski @borismo @dirrao @phi-friday @Ghoul-SSZ @joaopamaral @BTeclaw @potiuk @vikramaditya91 @uzhastik @ambika-garg @Owen-CH-Leung @moiseenkov @ssilb4 @got686-yandex @kaxil @vincbeck @le

Committer

  • I acknowledge that I am a maintainer/committer of the Apache Airflow project.
@eladkal eladkal added kind:meta High-level information important to the community testing status Status of testing releases labels Aug 19, 2024
@moiseenkov
Copy link
Contributor

Hi,
#41527, #41262 work as expected

@phi-friday
Copy link
Contributor

  1. feat(docker): Replace use_dill with serializer #41356 works fine.
  2. fix: resolve AirflowProviderDeprecationWarning in spark provider #41358 I didn't use spark so I can't check, but given that _sql is simply an alias for sql, it should be fine.
  3. fix: rm deprecated import in common.sql #41461 I couldn't find a good way to verify common.sql, but since we've only removed the part that generates a more detailed error message, it should be fine.

@potiuk
Copy link
Member

potiuk commented Aug 19, 2024

Hi, since there haven’t been any recent updates for the Teradata Provider beyond version 2.5.0, could you explain why a new release version is needed?

According to our rules - periodically we bump all providers min-airflow version. https://github.com/apache/airflow/blob/main/PROVIDERS.rst#upgrading-minimum-supported-version-of-airflow -> then we relaease all providers with min-airflow version bumped - we also remove all pre-min-airflow backports, this allows to keep airflow providers free from back-compatibility issues.

@potiuk
Copy link
Member

potiuk commented Aug 19, 2024

Checked that all my changes are in.

@jx2lee
Copy link
Contributor

jx2lee commented Aug 19, 2024

@eladkal
#40008 works fine! (unittest & example run)

@Owen-CH-Leung
Copy link
Contributor

@eladkal the ElasticSearchSQLHook is now working as expected.

image

@vikramaditya91
Copy link
Contributor

#41256: @vikramaditya91

Works fine

@kacpermuda
Copy link
Contributor

#41494 tried to fix the OOM error in the scheduler that the OpenLineage can cause when generating a dag_tree from a huge DAG (related issue: #41505). It works but we've just got information about another production case where the scheduler went OOM with another complex DAG. There is a fix prepared in #41587 that will remove the dag_tree entirely so there will no more errors like this. I'd like to request an rc2 for OpenLineage provider (@eladkal) that will include that fix, as it is a bug that can cause some problems in bigger deployments.

@joaopamaral
Copy link
Contributor

joaopamaral commented Aug 19, 2024

Tested #40703 with both access_control formats and it's working fine:

image

airflow-oss-bot added a commit to astronomer/astronomer-providers that referenced this issue Aug 20, 2024
@eladkal
Copy link
Contributor Author

eladkal commented Aug 20, 2024

@kacpermuda I will exclude openlineage from this release

@uzhastik
Copy link
Contributor

ydb provider works fine: #41303

@ambika-garg
Copy link
Contributor

Hi, #40356 work as expected

@dirrao
Copy link
Collaborator

dirrao commented Aug 20, 2024

Hi,
#41372 address the documentation changes. So, no functionality change.

@BTeclaw
Copy link
Contributor

BTeclaw commented Aug 20, 2024

#41150 - Works as expected - unit test + functional check, details below:

  1. Connection definition (different role and warehouse than is used on Operator definition)
    connection_definition
  2. DAG definition, mind the different warehouse, role and schema
    dag_definition
  3. Queries executed on a warehouse defined when declaring the SnowflakeSqlApiOperator and not the connection
    proper_warehouse
  4. DDL executing role is also properly forwarded through the SnowflakeSqlApiOperator
    proper_owner_of_table

@perry2of5
Copy link
Contributor

perry2of5 commented Aug 21, 2024

41142 passes test, but:

I noticed is that starting with 2.9.3 with microsoft-azure providers 10.3.0 the return value quits being put into XCOM (it is blank in the UI). Then with airflow 2.10.0 with microsoft-azure providers 10.3.0 the key shows up in XCOM but it says "No value found for XCom key". So something broke between 2.9.2 / 10.1.2 and 2.10.0/10.3.0.

With all that said, my actual change to put the last line (or all lines) of the logs into XCOM worked. So, I think we need a new defect logged to see why return value isn't showing up correctly any more.

Here is my operator. I'd been testing my changes with do_xcom_push=False since I didn't care about the normal return_value...obscured the fact something else broke :(

  aciOperator = AzureContainerInstancesOperator(
      ci_conn_id="azure-container-instance-conn-id",
      registry_conn_id="acr-conn-id",
      resource_group="redacted",
      name="http2blob{{ ds }}",
      image='redacted',
      region="WestUS2",
      environment_variables={
      redacted
      },
      volumes=[],
      memory_in_gb=1.0,
      cpu=1.0,
      task_id="start-download-aci",
      retries=0,
      do_xcom_push=True,
      # xcom_all=True,
      post_execute=_post_execute,
  )

Also, I did some more testing and multiple_outputs=True also fails back in 2.9.2 with microsoft-azure providers 10.1.2. This actually makes sense because the operator returns a single value, not a dictionary so I think this wasn't actually an issue. So, I'm saying this was tester error unless someone tells me otherwise.

@eladkal
Copy link
Contributor Author

eladkal commented Aug 21, 2024

@perry2of5 there is only 1 question relevant here. Is there regression in apache-airflow-providers-microsoft-azure from 10.4.0rc1 to 10.3.0 ? All the rest is possible bugs that do not affect our decision about releasing.

Please clarify explicitly what worked on 10.3.0 and does not work anymore on 10.4.0rc1

@perry2of5
Copy link
Contributor

I did not find any regression from 10.3.0 to 10.4.0rc1.

@eladkal
Copy link
Contributor Author

eladkal commented Aug 22, 2024

I did not find any regression from 10.3.0 to 10.4.0rc1.

Then it's not blocking the release.
Feel free to raise PR to address the bugs you mentioned

@eladkal
Copy link
Contributor Author

eladkal commented Aug 22, 2024

Thank you everyone. Providers are released.
Provider openlineage is excluded and will followup with rc2

I invite everyone to help improve providers for the next release, a list of open issues can be found here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers kind:meta High-level information important to the community testing status Status of testing releases
Projects
None yet
Development

No branches or pull requests