From f8d57e5efad9fa16f3249a43780af93b0e907ad7 Mon Sep 17 00:00:00 2001 From: Kaxil Naik Date: Sat, 22 Aug 2020 19:49:58 +0100 Subject: [PATCH] Fix typo in Facebook Ads Provider `missings_keys` -> `missing_keys` --- airflow/providers/facebook/ads/hooks/ads.py | 6 +++--- .../cloud/transfers/test_facebook_ads_to_gcs_system.py | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/airflow/providers/facebook/ads/hooks/ads.py b/airflow/providers/facebook/ads/hooks/ads.py index e2e06ec010a02..c8f01aba0b482 100644 --- a/airflow/providers/facebook/ads/hooks/ads.py +++ b/airflow/providers/facebook/ads/hooks/ads.py @@ -89,9 +89,9 @@ def facebook_ads_config(self) -> Dict: self.log.info("Fetching fb connection: %s", self.facebook_conn_id) conn = self.get_connection(self.facebook_conn_id) config = conn.extra_dejson - missings_keys = self.client_required_fields - config.keys() - if missings_keys: - message = "{missings_keys} fields are missing".format(missings_keys=missings_keys) + missing_keys = self.client_required_fields - config.keys() + if missing_keys: + message = "{missing_keys} fields are missing".format(missing_keys=missing_keys) raise AirflowException(message) return config diff --git a/tests/providers/google/cloud/transfers/test_facebook_ads_to_gcs_system.py b/tests/providers/google/cloud/transfers/test_facebook_ads_to_gcs_system.py index bf107e6e6e985..143768c03f921 100644 --- a/tests/providers/google/cloud/transfers/test_facebook_ads_to_gcs_system.py +++ b/tests/providers/google/cloud/transfers/test_facebook_ads_to_gcs_system.py @@ -56,9 +56,9 @@ def provide_facebook_connection( ) with open(key_file_path, 'r') as credentials: creds = json.load(credentials) - missings_keys = CONFIG_REQUIRED_FIELDS - creds.keys() - if missings_keys: - message = "{missings_keys} fields are missing".format(missings_keys=missings_keys) + missing_keys = CONFIG_REQUIRED_FIELDS - creds.keys() + if missing_keys: + message = "{missing_keys} fields are missing".format(missing_keys=missing_keys) raise AirflowException(message) conn = Connection( conn_id=FACEBOOK_CONNECTION_ID,