Skip to content

Update kubernetes.rst#14358

Closed
zbstof wants to merge 1 commit into
apache:masterfrom
zbstof:patch-1
Closed

Update kubernetes.rst#14358
zbstof wants to merge 1 commit into
apache:masterfrom
zbstof:patch-1

Conversation

@zbstof
Copy link
Copy Markdown
Contributor

@zbstof zbstof commented Feb 22, 2021

Diagram for success case in "KubernetesExecutor Architecture" is inconsistent with diagram for "Handling Worker Pod Crashes"
Either success case shouldn't specify that error reporting should be done to db from the pod only in some specific case, or removed (as I've done in this PR)

Diagram for success case in "KubernetesExecutor Architecture" is inconsistent with diagram for "Handling Worker Pod Crashes"
Either success case shouldn't specify that error reporting should be done to db from the pod only in some specific case, or removed (as I've done in this PR)
@boring-cyborg
Copy link
Copy Markdown

boring-cyborg Bot commented Feb 22, 2021

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, pylint and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@zbstof zbstof closed this Feb 22, 2021
@zbstof zbstof deleted the patch-1 branch February 22, 2021 13:36
@zbstof
Copy link
Copy Markdown
Contributor Author

zbstof commented Feb 22, 2021

My mistake - task can complete normally, but still fail

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant