Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce formatting on helm chart json schema files #15895

Merged
merged 1 commit into from May 17, 2021

Conversation

jedcunningham
Copy link
Member

This enables a json formatter on the helm chart json schema files. I'm not dead-set on having this but after working in the schema a bit lately having an enforced and consistent format would be nice.

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label May 17, 2021
@github-actions
Copy link

The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest master or amend the last commit of the PR, and push it with --force-with-lease.

@potiuk potiuk merged commit b2de542 into apache:master May 17, 2021
@kaxil kaxil deleted the format_chart_json branch May 17, 2021 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dev-tools okay to merge It's ok to merge this PR as it does not require more tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants