Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make task ID on legend have enough width and width of line chart to be 100%. #15915

Merged
merged 4 commits into from Jun 10, 2021

Conversation

@PengMingHua905001
Copy link
Contributor

@PengMingHua905001 PengMingHua905001 commented May 18, 2021

Annotation 2021-05-18 171131
On Task Duration/Task Tries/Lading Times, the full name of task ID is cutted and end with '...' if lenght is over that 20 characters. So we make task ID have enough width (max length: 200 characters ) to be displayed and let user can find out matched Task ID when pressing CTRL+F and inputting long text.
Width of line chart was set to 1200 , it looks not good for big screens, it should be 100% width.
Please compare the before and after screenshot.
Before:
before
After:
after

@boring-cyborg
Copy link

@boring-cyborg boring-cyborg bot commented May 18, 2021

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, pylint and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@ashb ashb requested a review from bbovenzi May 18, 2021
Copy link
Contributor

@bbovenzi bbovenzi left a comment

Lgtm. but it may be helpful to show a before and after screenshot in the PR.

@PengMingHua905001
Copy link
Contributor Author

@PengMingHua905001 PengMingHua905001 commented May 19, 2021

Add before and after screenshot

@uranusjr
Copy link
Member

@uranusjr uranusjr commented May 19, 2021

What happens if the screen width is below 1200px, or much narrower? I would want the chart to have a minimal width so it is still usable on small screens.

@PengMingHua905001
Copy link
Contributor Author

@PengMingHua905001 PengMingHua905001 commented May 20, 2021

image
It looks good on ipad simulated on chrome.

@github-actions
Copy link

@github-actions github-actions bot commented May 25, 2021

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.

Copy link
Contributor

@ryanahamilton ryanahamilton left a comment

Looks like some pylint errors need fixing

@jhtimmins
Copy link
Contributor

@jhtimmins jhtimmins commented Jun 9, 2021

@ryanahamilton can you take a look and confirm whether your requested changes have been addressed?

@ryanahamilton ryanahamilton merged commit 6e9e562 into apache:main Jun 10, 2021
13 checks passed
@boring-cyborg
Copy link

@boring-cyborg boring-cyborg bot commented Jun 10, 2021

Awesome work, congrats on your first merged pull request!

jedcunningham added a commit to astronomer/airflow that referenced this issue Jun 10, 2021
kaxil pushed a commit that referenced this issue Jun 10, 2021
@ashb ashb added this to the Airflow 2.1.1 milestone Jun 11, 2021
jhtimmins added a commit to astronomer/airflow that referenced this issue Jun 15, 2021
…e 100%. (apache#15915)

* Make task ID on legend have enough width and width of line chart to be 100%.

* Make task ID on legend have enough width and width of line chart to be 100%.

* Fix pylint errors.

(cherry picked from commit 6e9e562)
ashb added a commit that referenced this issue Jun 22, 2021
…e 100%. (#15915)

* Make task ID on legend have enough width and width of line chart to be 100%.

* Make task ID on legend have enough width and width of line chart to be 100%.

* Fix pylint errors.

(cherry picked from commit 6e9e562)
kaxil added a commit to astronomer/airflow that referenced this issue Jun 22, 2021
…e 100%. (apache#15915)

* Make task ID on legend have enough width and width of line chart to be 100%.

* Make task ID on legend have enough width and width of line chart to be 100%.

* Fix pylint errors.

(cherry picked from commit 6e9e562)
(cherry picked from commit fb62867)
kaxil added a commit to astronomer/airflow that referenced this issue Jun 23, 2021
…e 100%. (apache#15915)

* Make task ID on legend have enough width and width of line chart to be 100%.

* Make task ID on legend have enough width and width of line chart to be 100%.

* Fix pylint errors.

(cherry picked from commit 6e9e562)
(cherry picked from commit fb62867)
(cherry picked from commit 8b2a7b7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants