Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Dag Details start date bug #16206

Merged
merged 4 commits into from Jun 8, 2021

Conversation

@bbovenzi
Copy link
Contributor

@bbovenzi bbovenzi commented Jun 1, 2021

Fix error of the start date being wrong when catchup=False by hiding the Start Date and by adding catchup as a field in Dag Details

Closes #14299

Screen Shot 2021-06-01 at 2 33 32 PM

Screen Shot 2021-06-01 at 2 33 50 PM


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@bbovenzi
Copy link
Contributor Author

@bbovenzi bbovenzi commented Jun 1, 2021

@uranusjr Couldn't request a review from you but here's the fix.

@uranusjr
Copy link
Member

@uranusjr uranusjr commented Jun 1, 2021

How do I tell if the DAG has started in the proposed UI? I was imaginging there would be an indicator or a started=False row, but that doesn’t seem to be the case here.

@bbovenzi
Copy link
Contributor Author

@bbovenzi bbovenzi commented Jun 2, 2021

Updated. It will either show the Start Date or Started: True/False

Screen Shot 2021-06-01 at 10 40 53 PM

@ryanahamilton ryanahamilton merged commit ebc03c6 into apache:main Jun 8, 2021
32 of 33 checks passed
@ryanahamilton ryanahamilton deleted the catchup-false-hide-startdate branch Jun 8, 2021
jhtimmins added a commit to astronomer/airflow that referenced this issue Jun 22, 2021
* Only show Start Date when catchup=True

* add catchup field to details

* add started field for catchup=false dags

(cherry picked from commit ebc03c6)
@ashb ashb added this to the Airflow 2.1.1 milestone Jun 22, 2021
ashb added a commit that referenced this issue Jun 22, 2021
* Only show Start Date when catchup=True

* add catchup field to details

* add started field for catchup=false dags

(cherry picked from commit ebc03c6)
kaxil added a commit to astronomer/airflow that referenced this issue Jun 22, 2021
* Only show Start Date when catchup=True

* add catchup field to details

* add started field for catchup=false dags

(cherry picked from commit ebc03c6)
(cherry picked from commit 8114542)
kaxil added a commit to astronomer/airflow that referenced this issue Jun 23, 2021
* Only show Start Date when catchup=True

* add catchup field to details

* add started field for catchup=false dags

(cherry picked from commit ebc03c6)
(cherry picked from commit 8114542)
(cherry picked from commit 8d40ce4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants