Exclude Yarn.lock to be built into python wheel #16494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaxil
approved these changes
Jun 16, 2021
|
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
okay to merge
|
Awesome work, congrats on your first merged pull request! |
jedcunningham
added a commit
to astronomer/airflow
that referenced
this pull request
Jun 17, 2021
This reverts commit a76a67c.
kaxil
pushed a commit
that referenced
this pull request
Jun 18, 2021
kaxil
added a commit
to astronomer/airflow
that referenced
this pull request
Jun 22, 2021
Same as apache#16494 - However that PR had to be reverted in apache#16518 as it failed building of PROD image, this PR/commit will fix it. PROBLEM: Currently the airflow wheel is built with the yarn.lock which is not actually used by the airflow itself. Having this file in the docker image causes the clair and trivy scanners to fail FIX: The fix is to exclude the yarn.lock by specifying it in the manifest.in
kaxil
added a commit
that referenced
this pull request
Jun 22, 2021
Same as #16494 - However that PR had to be reverted in #16518 as it failed building of PROD image, this PR/commit will fix it. PROBLEM: Currently the airflow wheel is built with the yarn.lock which is not actually used by the airflow itself. Having this file in the docker image causes the clair and trivy scanners to fail FIX: The fix is to exclude the yarn.lock by specifying it in the manifest.in
ashb
pushed a commit
that referenced
this pull request
Jun 22, 2021
Same as #16494 - However that PR had to be reverted in #16518 as it failed building of PROD image, this PR/commit will fix it. PROBLEM: Currently the airflow wheel is built with the yarn.lock which is not actually used by the airflow itself. Having this file in the docker image causes the clair and trivy scanners to fail FIX: The fix is to exclude the yarn.lock by specifying it in the manifest.in (cherry picked from commit aa79bfe)
kaxil
added a commit
to astronomer/airflow
that referenced
this pull request
Jun 22, 2021
Same as apache#16494 - However that PR had to be reverted in apache#16518 as it failed building of PROD image, this PR/commit will fix it. PROBLEM: Currently the airflow wheel is built with the yarn.lock which is not actually used by the airflow itself. Having this file in the docker image causes the clair and trivy scanners to fail FIX: The fix is to exclude the yarn.lock by specifying it in the manifest.in (cherry picked from commit aa79bfe)
kaxil
added a commit
to astronomer/airflow
that referenced
this pull request
Jun 23, 2021
Same as apache#16494 - However that PR had to be reverted in apache#16518 as it failed building of PROD image, this PR/commit will fix it. PROBLEM: Currently the airflow wheel is built with the yarn.lock which is not actually used by the airflow itself. Having this file in the docker image causes the clair and trivy scanners to fail FIX: The fix is to exclude the yarn.lock by specifying it in the manifest.in (cherry picked from commit aa79bfe) (cherry picked from commit 8fcc68d)
kaxil
added a commit
to astronomer/airflow
that referenced
this pull request
Jun 23, 2021
Same as apache#16494 - However that PR had to be reverted in apache#16518 as it failed building of PROD image, this PR/commit will fix it. PROBLEM: Currently the airflow wheel is built with the yarn.lock which is not actually used by the airflow itself. Having this file in the docker image causes the clair and trivy scanners to fail FIX: The fix is to exclude the yarn.lock by specifying it in the manifest.in (cherry picked from commit aa79bfe) (cherry picked from commit 8fcc68d) (cherry picked from commit 99d5ebd)
Jorricks
pushed a commit
to Jorricks/airflow
that referenced
this pull request
Jun 24, 2021
Same as apache#16494 - However that PR had to be reverted in apache#16518 as it failed building of PROD image, this PR/commit will fix it. PROBLEM: Currently the airflow wheel is built with the yarn.lock which is not actually used by the airflow itself. Having this file in the docker image causes the clair and trivy scanners to fail FIX: The fix is to exclude the yarn.lock by specifying it in the manifest.in
kaxil
added a commit
to astronomer/airflow
that referenced
this pull request
Jul 14, 2021
Same as apache#16494 - However that PR had to be reverted in apache#16518 as it failed building of PROD image, this PR/commit will fix it. PROBLEM: Currently the airflow wheel is built with the yarn.lock which is not actually used by the airflow itself. Having this file in the docker image causes the clair and trivy scanners to fail FIX: The fix is to exclude the yarn.lock by specifying it in the manifest.in (cherry picked from commit aa79bfe)
kaxil
added a commit
to astronomer/airflow
that referenced
this pull request
Jul 20, 2021
Same as apache#16494 - However that PR had to be reverted in apache#16518 as it failed building of PROD image, this PR/commit will fix it. PROBLEM: Currently the airflow wheel is built with the yarn.lock which is not actually used by the airflow itself. Having this file in the docker image causes the clair and trivy scanners to fail FIX: The fix is to exclude the yarn.lock by specifying it in the manifest.in (cherry picked from commit aa79bfe) (cherry picked from commit 6c80e3f)
kaxil
added a commit
to astronomer/airflow
that referenced
this pull request
Jul 21, 2021
Same as apache#16494 - However that PR had to be reverted in apache#16518 as it failed building of PROD image, this PR/commit will fix it. PROBLEM: Currently the airflow wheel is built with the yarn.lock which is not actually used by the airflow itself. Having this file in the docker image causes the clair and trivy scanners to fail FIX: The fix is to exclude the yarn.lock by specifying it in the manifest.in (cherry picked from commit aa79bfe) (cherry picked from commit 6c80e3f) (cherry picked from commit 25d46e4)
kaxil
added a commit
to astronomer/airflow
that referenced
this pull request
Jul 21, 2021
Same as apache#16494 - However that PR had to be reverted in apache#16518 as it failed building of PROD image, this PR/commit will fix it. PROBLEM: Currently the airflow wheel is built with the yarn.lock which is not actually used by the airflow itself. Having this file in the docker image causes the clair and trivy scanners to fail FIX: The fix is to exclude the yarn.lock by specifying it in the manifest.in (cherry picked from commit aa79bfe) (cherry picked from commit 6c80e3f) (cherry picked from commit 25d46e4)
kaxil
added a commit
to astronomer/airflow
that referenced
this pull request
Jul 21, 2021
Same as apache#16494 - However that PR had to be reverted in apache#16518 as it failed building of PROD image, this PR/commit will fix it. PROBLEM: Currently the airflow wheel is built with the yarn.lock which is not actually used by the airflow itself. Having this file in the docker image causes the clair and trivy scanners to fail FIX: The fix is to exclude the yarn.lock by specifying it in the manifest.in (cherry picked from commit aa79bfe) (cherry picked from commit 6c80e3f) (cherry picked from commit 25d46e4)
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Sep 17, 2021
Same as apache/airflow#16494 - However that PR had to be reverted in apache/airflow#16518 as it failed building of PROD image, this PR/commit will fix it. PROBLEM: Currently the airflow wheel is built with the yarn.lock which is not actually used by the airflow itself. Having this file in the docker image causes the clair and trivy scanners to fail FIX: The fix is to exclude the yarn.lock by specifying it in the manifest.in (cherry picked from commit aa79bfe7e71f5e90dbfb3f2deb3ad5b44e3259ab) GitOrigin-RevId: 2682df6c6888c40fd790439c3be60c282f1d7f16
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Sep 23, 2021
Same as apache/airflow#16494 - However that PR had to be reverted in apache/airflow#16518 as it failed building of PROD image, this PR/commit will fix it. PROBLEM: Currently the airflow wheel is built with the yarn.lock which is not actually used by the airflow itself. Having this file in the docker image causes the clair and trivy scanners to fail FIX: The fix is to exclude the yarn.lock by specifying it in the manifest.in (cherry picked from commit aa79bfe7e71f5e90dbfb3f2deb3ad5b44e3259ab) GitOrigin-RevId: 2682df6c6888c40fd790439c3be60c282f1d7f16
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Nov 27, 2021
Same as apache/airflow#16494 - However that PR had to be reverted in apache/airflow#16518 as it failed building of PROD image, this PR/commit will fix it. PROBLEM: Currently the airflow wheel is built with the yarn.lock which is not actually used by the airflow itself. Having this file in the docker image causes the clair and trivy scanners to fail FIX: The fix is to exclude the yarn.lock by specifying it in the manifest.in (cherry picked from commit aa79bfe7e71f5e90dbfb3f2deb3ad5b44e3259ab) GitOrigin-RevId: 2682df6c6888c40fd790439c3be60c282f1d7f16
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Mar 10, 2022
Same as apache/airflow#16494 - However that PR had to be reverted in apache/airflow#16518 as it failed building of PROD image, this PR/commit will fix it. PROBLEM: Currently the airflow wheel is built with the yarn.lock which is not actually used by the airflow itself. Having this file in the docker image causes the clair and trivy scanners to fail FIX: The fix is to exclude the yarn.lock by specifying it in the manifest.in GitOrigin-RevId: aa79bfe7e71f5e90dbfb3f2deb3ad5b44e3259ab
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Jun 4, 2022
Same as apache/airflow#16494 - However that PR had to be reverted in apache/airflow#16518 as it failed building of PROD image, this PR/commit will fix it. PROBLEM: Currently the airflow wheel is built with the yarn.lock which is not actually used by the airflow itself. Having this file in the docker image causes the clair and trivy scanners to fail FIX: The fix is to exclude the yarn.lock by specifying it in the manifest.in GitOrigin-RevId: aa79bfe7e71f5e90dbfb3f2deb3ad5b44e3259ab
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Jul 10, 2022
Same as apache/airflow#16494 - However that PR had to be reverted in apache/airflow#16518 as it failed building of PROD image, this PR/commit will fix it. PROBLEM: Currently the airflow wheel is built with the yarn.lock which is not actually used by the airflow itself. Having this file in the docker image causes the clair and trivy scanners to fail FIX: The fix is to exclude the yarn.lock by specifying it in the manifest.in GitOrigin-RevId: aa79bfe7e71f5e90dbfb3f2deb3ad5b44e3259ab
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Aug 27, 2022
Same as apache/airflow#16494 - However that PR had to be reverted in apache/airflow#16518 as it failed building of PROD image, this PR/commit will fix it. PROBLEM: Currently the airflow wheel is built with the yarn.lock which is not actually used by the airflow itself. Having this file in the docker image causes the clair and trivy scanners to fail FIX: The fix is to exclude the yarn.lock by specifying it in the manifest.in GitOrigin-RevId: aa79bfe7e71f5e90dbfb3f2deb3ad5b44e3259ab
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Oct 4, 2022
Same as apache/airflow#16494 - However that PR had to be reverted in apache/airflow#16518 as it failed building of PROD image, this PR/commit will fix it. PROBLEM: Currently the airflow wheel is built with the yarn.lock which is not actually used by the airflow itself. Having this file in the docker image causes the clair and trivy scanners to fail FIX: The fix is to exclude the yarn.lock by specifying it in the manifest.in GitOrigin-RevId: aa79bfe7e71f5e90dbfb3f2deb3ad5b44e3259ab
aglipska
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Oct 7, 2022
Same as apache/airflow#16494 - However that PR had to be reverted in apache/airflow#16518 as it failed building of PROD image, this PR/commit will fix it. PROBLEM: Currently the airflow wheel is built with the yarn.lock which is not actually used by the airflow itself. Having this file in the docker image causes the clair and trivy scanners to fail FIX: The fix is to exclude the yarn.lock by specifying it in the manifest.in GitOrigin-RevId: aa79bfe7e71f5e90dbfb3f2deb3ad5b44e3259ab
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Dec 7, 2022
Same as apache/airflow#16494 - However that PR had to be reverted in apache/airflow#16518 as it failed building of PROD image, this PR/commit will fix it. PROBLEM: Currently the airflow wheel is built with the yarn.lock which is not actually used by the airflow itself. Having this file in the docker image causes the clair and trivy scanners to fail FIX: The fix is to exclude the yarn.lock by specifying it in the manifest.in GitOrigin-RevId: aa79bfe7e71f5e90dbfb3f2deb3ad5b44e3259ab
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Jan 27, 2023
Same as apache/airflow#16494 - However that PR had to be reverted in apache/airflow#16518 as it failed building of PROD image, this PR/commit will fix it. PROBLEM: Currently the airflow wheel is built with the yarn.lock which is not actually used by the airflow itself. Having this file in the docker image causes the clair and trivy scanners to fail FIX: The fix is to exclude the yarn.lock by specifying it in the manifest.in GitOrigin-RevId: aa79bfe7e71f5e90dbfb3f2deb3ad5b44e3259ab
kosteev
pushed a commit
to kosteev/composer-airflow-test-copybara
that referenced
this pull request
Sep 12, 2024
Same as apache/airflow#16494 - However that PR had to be reverted in apache/airflow#16518 as it failed building of PROD image, this PR/commit will fix it. PROBLEM: Currently the airflow wheel is built with the yarn.lock which is not actually used by the airflow itself. Having this file in the docker image causes the clair and trivy scanners to fail FIX: The fix is to exclude the yarn.lock by specifying it in the manifest.in GitOrigin-RevId: aa79bfe7e71f5e90dbfb3f2deb3ad5b44e3259ab
kosteev
pushed a commit
to kosteev/composer-airflow-test-copybara
that referenced
this pull request
Sep 13, 2024
Same as apache/airflow#16494 - However that PR had to be reverted in apache/airflow#16518 as it failed building of PROD image, this PR/commit will fix it. PROBLEM: Currently the airflow wheel is built with the yarn.lock which is not actually used by the airflow itself. Having this file in the docker image causes the clair and trivy scanners to fail FIX: The fix is to exclude the yarn.lock by specifying it in the manifest.in GitOrigin-RevId: aa79bfe7e71f5e90dbfb3f2deb3ad5b44e3259ab
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Sep 17, 2024
Same as apache/airflow#16494 - However that PR had to be reverted in apache/airflow#16518 as it failed building of PROD image, this PR/commit will fix it. PROBLEM: Currently the airflow wheel is built with the yarn.lock which is not actually used by the airflow itself. Having this file in the docker image causes the clair and trivy scanners to fail FIX: The fix is to exclude the yarn.lock by specifying it in the manifest.in GitOrigin-RevId: aa79bfe7e71f5e90dbfb3f2deb3ad5b44e3259ab
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PROBLEM: Currently the airflow wheel is built with the yarn.lock which is not actually used by the airflow itself. Having this file in the docker image causes the clair and trivy scanners to fail
FIX: The fix is to exclude the yarn.lock by specifying it in the manifest.in
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.