Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always install sphinx_airflow_theme from pypi #16594

Merged
merged 1 commit into from Jun 22, 2021

Conversation

@ashb
Copy link
Member

@ashb ashb commented Jun 22, 2021

We don't need a way to specify in setup.py that this should be
installed from a GitHub release -- it's never needed by users, and if
you are developing the theme you can install the custom version
yourself.

(The variable name is confusing too -- it wasn't pulling from git, but
from a published release on GitHub.)

Removing this just means one less thing to update.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

We don't need a way to specify _in_ setup.py that this should be
installed from a GitHub release -- it's never needed by users, and if
you are developing the theme you can install the custom version
yourself.

(The variable name is confusing too -- it wasn't pulling from git, but
from a published release on GitHub.)

Removing this just means one less thing to update.
Copy link
Member

@uranusjr uranusjr left a comment

Any oppertunity to avoid setup.py magic is an automatic +1 from me 🙂

potiuk
potiuk approved these changes Jun 22, 2021
@ashb ashb merged commit 129fc61 into apache:main Jun 22, 2021
32 of 33 checks passed
@ashb ashb deleted the update-sphinx-theme-version branch Jun 22, 2021
ashb added a commit that referenced this issue Jun 22, 2021
We don't need a way to specify _in_ setup.py that this should be
installed from a GitHub release -- it's never needed by users, and if
you are developing the theme you can install the custom version
yourself.

(The variable name is confusing too -- it wasn't pulling from git, but
from a published release on GitHub.)

Removing this just means one less thing to update.

(cherry picked from commit 129fc61)
Jorricks added a commit to Jorricks/airflow that referenced this issue Jun 24, 2021
We don't need a way to specify _in_ setup.py that this should be
installed from a GitHub release -- it's never needed by users, and if
you are developing the theme you can install the custom version
yourself.

(The variable name is confusing too -- it wasn't pulling from git, but
from a published release on GitHub.)

Removing this just means one less thing to update.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants