Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Invalid JSON configuration, must be a dict" #16648

Merged
merged 1 commit into from Jun 27, 2021
Merged

Fix "Invalid JSON configuration, must be a dict" #16648

merged 1 commit into from Jun 27, 2021

Conversation

@microhuang
Copy link
Contributor

@microhuang microhuang commented Jun 25, 2021

Wrong variable name used


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@boring-cyborg
Copy link

@boring-cyborg boring-cyborg bot commented Jun 25, 2021

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, pylint and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@uranusjr
Copy link
Member

@uranusjr uranusjr commented Jun 25, 2021

For other reviewers: conf is a global variable made available by from airflow import conf. The trigger view does not contain a conf local variable, only request_conf = request.values.get("conf"), default_conf (either request_conf or json.dumps(dag.params)), and run_conf populated here.

kaxil
kaxil approved these changes Jun 26, 2021
@kaxil kaxil added this to the Airflow 2.1.2 milestone Jun 26, 2021
@kaxil
Copy link
Member

@kaxil kaxil commented Jun 26, 2021

Thanks @microhuang

@github-actions
Copy link

@github-actions github-actions bot commented Jun 26, 2021

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

msumit
msumit approved these changes Jun 27, 2021
@uranusjr uranusjr merged commit c975d4c into apache:main Jun 27, 2021
34 checks passed
@boring-cyborg
Copy link

@boring-cyborg boring-cyborg bot commented Jun 27, 2021

Awesome work, congrats on your first merged pull request!

sthagen added a commit to sthagen/apache-airflow that referenced this issue Jun 27, 2021
Fix "Invalid JSON configuration, must be a dict" (apache#16648)
kaxil added a commit that referenced this issue Jul 5, 2021
Wrong variable name used

(cherry picked from commit c975d4c)
kaxil added a commit that referenced this issue Jul 5, 2021
Wrong variable name used

(cherry picked from commit c975d4c)
kaxil added a commit to astronomer/airflow that referenced this issue Jul 5, 2021
Wrong variable name used

(cherry picked from commit c975d4c)
(cherry picked from commit 4157346)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants