Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick 3 9 support to v2 1 #16883

Merged
merged 1 commit into from Jul 8, 2021

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented Jul 8, 2021


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

This includes several things:

* added per-provider support for python version. Each provider
  can now declare python versions it does not support
* excluded ldap core extra from Python 3.9.
* skip relevant tests in Python 3.9

(cherry picked from commit ce44b62)
@potiuk
Copy link
Member Author

@potiuk potiuk commented Jul 8, 2021

It was rather easy to cherry-pick that one - almost no conflicts and the ones that were there were only in elasticsearch (which is ignored in non-main branch) and in breeze/scripts. Since we have ~ 3 months to release 2.2, I think it's worth to merge it now. But if it will cause any problems, I am ok with doing it as part of 2.1.3 as well @jhtimmins @ashb

@potiuk potiuk closed this Jul 8, 2021
@potiuk potiuk reopened this Jul 8, 2021
@potiuk
Copy link
Member Author

@potiuk potiuk commented Jul 8, 2021

Closed/reopened to trigger tests for all python versions

@ashb
Copy link
Member

@ashb ashb commented Jul 8, 2021

@potiuk I was trying to keep 2.1.2 as small as possible (to minimize testing and to only fix the regressions from 2.1.0), so my instinct is to wait on merging this until 2.1.2 is out, and then include this in 2.1.3 (due towards the end of this month).

@ashb
Copy link
Member

@ashb ashb commented Jul 8, 2021

That said, this has no changes on core itself, so 👍🏻

ashb
ashb approved these changes Jul 8, 2021
@potiuk
Copy link
Member Author

@potiuk potiuk commented Jul 8, 2021

Ah. Ut will need to be merged to get 3.9 updated in v2-1-stable to actually run the 3.9 build. I will merge it and in case we find any problem we can revert it. I built it manually so it should be fine.

@potiuk potiuk merged commit dcffcc1 into apache:v2-1-stable Jul 8, 2021
35 of 40 checks passed
@potiuk potiuk deleted the cherry-pick-3-9-support-to-v2-1 branch Jul 8, 2021
@potiuk
Copy link
Member Author

@potiuk potiuk commented Jul 8, 2021

Just to be fully sure of it before you wake up @jhtimmins I am running it all in my fork from main: https://github.com/potiuk/airflow/actions/runs/1011392229 and https://github.com/potiuk/airflow/runs/3018362289

@potiuk
Copy link
Member Author

@potiuk potiuk commented Jul 8, 2021

Yep. There were some errors (seems that the public GitHub Runners are very unstable) but image building and some Py3.9 tests succeeded , so it should be good to go

jhtimmins added a commit that referenced this issue Jul 8, 2021
This includes several things:

* added per-provider support for python version. Each provider
  can now declare python versions it does not support
* excluded ldap core extra from Python 3.9.
* skip relevant tests in Python 3.9

(cherry picked from commit ce44b62)
kaxil added a commit to astronomer/airflow that referenced this issue Jul 13, 2021
This includes several things:

* added per-provider support for python version. Each provider
  can now declare python versions it does not support
* excluded ldap core extra from Python 3.9.
* skip relevant tests in Python 3.9

(cherry picked from commit ce44b62)
(cherry picked from commit dcffcc1)
kaxil added a commit to astronomer/airflow that referenced this issue Jul 13, 2021
This includes several things:

* added per-provider support for python version. Each provider
  can now declare python versions it does not support
* excluded ldap core extra from Python 3.9.
* skip relevant tests in Python 3.9

(cherry picked from commit ce44b62)
(cherry picked from commit dcffcc1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants