Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix connection extra parameter auth_mechanism in HiveMetastoreHook and HiveServer2Hook #24713

Merged
merged 1 commit into from
Jun 29, 2022

Conversation

eladkal
Copy link
Contributor

@eladkal eladkal commented Jun 28, 2022

closes: #24692

I changed the parameter to auth_mechanism in order to keep the convention of the other extra parameters:
https://airflow.apache.org/docs/apache-airflow-providers-apache-hive/stable/connections/hiveserver2.html#configuring-the-connection
https://airflow.apache.org/docs/apache-airflow-providers-apache-hive/stable/connections/hive_metastore.html#configuring-the-connection

Part of the fix is also fixing the previous provider docs - see also apache/airflow-site#619


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragement file, named {pr_number}.significant.rst, in newsfragments.

eladkal pushed a commit to apache/airflow-site that referenced this pull request Jun 28, 2022
Fix to the code applied in apache/airflow#24713
for previous provider version we need to fix the docs to `authMechanism`
@eladkal eladkal requested a review from potiuk June 28, 2022 20:27
Copy link
Member

@kaxil kaxil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

potiuk pushed a commit to apache/airflow-site that referenced this pull request Jun 29, 2022
Fix to the code applied in apache/airflow#24713
for previous provider version we need to fix the docs to `authMechanism`

Co-authored-by: Elad Kalif <eladkal 45845474+eladkal@users.noreply.github.com>
Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is WAY smaller ;)

@potiuk potiuk merged commit cef97fc into apache:main Jun 29, 2022
@eladkal eladkal deleted the hive branch June 29, 2022 14:44
potiuk pushed a commit to apache/airflow-site that referenced this pull request Jun 17, 2023
Fix to the code applied in apache/airflow#24713
for previous provider version we need to fix the docs to `authMechanism`

Co-authored-by: Elad Kalif <eladkal 45845474+eladkal@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error for Hive Server2 Connection Document
3 participants