Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize TI.xcom_pull() with explicit task_ids and map_indexes #27699

Merged
merged 5 commits into from
Nov 21, 2022
Merged

Optimize TI.xcom_pull() with explicit task_ids and map_indexes #27699

merged 5 commits into from
Nov 21, 2022

Commits on Nov 18, 2022

  1. Optimize XCom.get_many() for map_indexes range 

    If the provided map_indexes value is a range with step=1, we can
optimize the query with >= and < instead of IN. This should be much more
efficient when the range contains many values.
    @uranusjr
    uranusjr committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    3d668bb View commit details
    Browse the repository at this point in the history

  2. Push xcom_pull() result sorting to database 

    Instead of eagerly pulling values from database and sort in Python, this
uses CASE to make the database perform the sorting. This should be more
performant in most cases, I think?
    @uranusjr
    uranusjr committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    496f689 View commit details
    Browse the repository at this point in the history

  3. Keep LazyXComAccess private

    @uranusjr
    uranusjr committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    c78c3bf View commit details
    Browse the repository at this point in the history

  4. Make LazyXComAccess behave more like list 

    This simplifies a lot of things.
    @uranusjr
    uranusjr committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    1bd31cc View commit details
    Browse the repository at this point in the history

  5. Also optimize range where step is -1

    @uranusjr
    uranusjr committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    13c590e View commit details
    Browse the repository at this point in the history