Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move local_infile option from extra to hook parameter #28811

Merged
merged 1 commit into from Jan 11, 2023

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Jan 9, 2023

This change is to move local_infile parameter from connection extra to Hook. Since this feature is only used for very specific cases, it belongs to the "action" it executes not to the connection defined in general. For example in Hive and Vertica transfers, the capability of local_inline is simply exnabled by bulk_load parameter - and it allows to use the same connection in both cases.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@potiuk potiuk force-pushed the remove-local-infile-in-mysql branch 2 times, most recently from b3f9c83 to 9bbf731 Compare January 10, 2023 07:42
@potiuk potiuk force-pushed the remove-local-infile-in-mysql branch from 9bbf731 to d0d7cc0 Compare January 10, 2023 10:35
This change is to move local_infile parameter from connection
extra to Hook. Since this feature is only used for very specific
cases, it belongs to the "action" it executes not to the connection
defined in general. For example in Hive and Vertica transfers, the
capability of local_inline is simply exnabled by bulk_load
parameter - and it allows to use the same connection in both cases.
@potiuk potiuk force-pushed the remove-local-infile-in-mysql branch from d0d7cc0 to a8c0e9c Compare January 10, 2023 21:07
@potiuk potiuk merged commit 45dd0c4 into apache:main Jan 11, 2023
38 checks passed
@potiuk potiuk deleted the remove-local-infile-in-mysql branch January 11, 2023 08:47
hussein-awala pushed a commit to hussein-awala/airflow that referenced this pull request Jan 12, 2023
This change is to move local_infile parameter from connection
extra to Hook. Since this feature is only used for very specific
cases, it belongs to the "action" it executes not to the connection
defined in general. For example in Hive and Vertica transfers, the
capability of local_inline is simply exnabled by bulk_load
parameter - and it allows to use the same connection in both cases.
Soonmok pushed a commit to Soonmok/airflow that referenced this pull request Jan 17, 2023
This change is to move local_infile parameter from connection
extra to Hook. Since this feature is only used for very specific
cases, it belongs to the "action" it executes not to the connection
defined in general. For example in Hive and Vertica transfers, the
capability of local_inline is simply exnabled by bulk_load
parameter - and it allows to use the same connection in both cases.
MrGeorgeOwl pushed a commit to lwyszomi/airflow that referenced this pull request Jan 18, 2023
This change is to move local_infile parameter from connection
extra to Hook. Since this feature is only used for very specific
cases, it belongs to the "action" it executes not to the connection
defined in general. For example in Hive and Vertica transfers, the
capability of local_inline is simply exnabled by bulk_load
parameter - and it allows to use the same connection in both cases.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants